From: Andrew Morton <akpm@linux-foundation.org>
To: Andi Kleen <ak@linux.intel.com>
Cc: Jason Wessel <jason.wessel@windriver.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][REGRESSION] panic: fix stack dump print on direct call to panic()
Date: Tue, 10 Apr 2012 12:19:49 -0700 [thread overview]
Message-ID: <20120410121949.71145057.akpm@linux-foundation.org> (raw)
In-Reply-To: <4F832BC8.4090907@linux.intel.com>
On Mon, 09 Apr 2012 11:34:48 -0700
Andi Kleen <ak@linux.intel.com> wrote:
> > The proper way to resolve the problem that original commit tried to
> > solve is to avoid printing a stack dump from panic() when the either
> > of the following conditions is true:
> >
> > 1) TAINT_DIE has been set (this is done by oops_end())
> > This indicates and oops has already been printed.
> > 2) oops_in_progress> 1
> > This guards against the rare case where panic() is invoked
> > a second time, or in between oops_begin() and oops_end()
>
> Oops. I guess can just revert it for now. Thanks for catching, Jason.
You're suggesting a revert of 6e6f0a1f0, but Jason is suggesting that
it be repaired. Confused.
next prev parent reply other threads:[~2012-04-10 19:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-09 17:20 [PATCH][REGRESSION] panic: fix stack dump print on direct call to panic() Jason Wessel
2012-04-09 18:34 ` Andi Kleen
2012-04-09 19:08 ` Jason Wessel
2012-04-09 19:36 ` Andi Kleen
2012-04-10 19:19 ` Andrew Morton [this message]
2012-04-10 23:29 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120410121949.71145057.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=ak@linux.intel.com \
--cc=jason.wessel@windriver.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox