From: Borislav Petkov <bp@amd64.org>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Ingo Molnar <mingo@kernel.org>,
Arnaldo Carvalho de Melo <acme@infradead.org>,
Michal Marek <mmarek@suse.cz>,
LKML <linux-kernel@vger.kernel.org>,
Borislav Petkov <borislav.petkov@amd.com>
Subject: Re: [PATCH v4 2/4] tools: Add a toplevel Makefile
Date: Tue, 10 Apr 2012 23:03:14 +0200 [thread overview]
Message-ID: <20120410210314.GC30366@aftab> (raw)
In-Reply-To: <20120410203348.GB28293@merkur.ravnborg.org>
On Tue, Apr 10, 2012 at 10:33:48PM +0200, Sam Ravnborg wrote:
> Things would be much simpler is all tools were adjusted to:
> a) the subdir they live in is the make target name
> b) each tool has three mandatory targets:
> 1) default target => build the tool
> 2) clean
> 3) install
>
> I can see that with the layout today you cannot
> distingush between the various targets below power.
> But the current solutions is not scaleable nor maintainable.
>
> Even if you cannot fix power/* then testing looks easy.
>
> But all that can always to improved and consolidated later.
Right, I was deliberating on whether to unify the dir layout so that it
fits with the Makefile targets nicely but decided to leave it out for
later. IOW, do the "one thing at a time" deal. Besides, some tools don't
have that clearly defined targets and selftests, for example, doesn't
need to be installed but simply run in a loop.
So definitely agreed, the tools/ dir could use a bunch of cultivating in
later cycles.
Thanks.
--
Regards/Gruss,
Boris.
Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
GM: Alberto Bozzo
Reg: Dornach, Landkreis Muenchen
HRB Nr. 43632 WEEE Registernr: 129 19551
next prev parent reply other threads:[~2012-04-10 21:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-10 15:20 [PATCH v4 0/4] tools: Add a toplevel Makefile Borislav Petkov
2012-04-10 15:20 ` [PATCH v4 1/4] tools: Add Makefile.include Borislav Petkov
2012-04-10 20:27 ` Sam Ravnborg
2012-04-10 20:58 ` Borislav Petkov
2012-04-10 15:20 ` [PATCH v4 2/4] tools: Add a toplevel Makefile Borislav Petkov
2012-04-10 20:33 ` Sam Ravnborg
2012-04-10 21:03 ` Borislav Petkov [this message]
2012-04-10 15:20 ` [PATCH v4 3/4] tools: Add a help target Borislav Petkov
2012-04-10 20:34 ` Sam Ravnborg
2012-04-10 15:20 ` [PATCH v4 4/4] tools: Connect to the kernel build system Borislav Petkov
2012-04-10 20:37 ` Sam Ravnborg
2012-04-10 21:04 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120410210314.GC30366@aftab \
--to=bp@amd64.org \
--cc=acme@infradead.org \
--cc=borislav.petkov@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mmarek@suse.cz \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox