From: Grant Likely <grant.likely@secretlab.ca>
To: Mika Westerberg <mika.westerberg@linux.intel.com>,
linux-kernel@vger.kernel.org
Cc: tglx@linutronix.de, benh@kernel.crashing.org,
Mika Westerberg <mika.westerberg@linux.intel.com>
Subject: Re: [PATCH 2/2] irq_domain: fix formatting of chip data pointer in virq_debug_show()
Date: Tue, 10 Apr 2012 17:27:08 -0600 [thread overview]
Message-ID: <20120410232708.CAC3D3E079B@localhost> (raw)
In-Reply-To: <1334060743-7901-2-git-send-email-mika.westerberg@linux.intel.com>
On Tue, 10 Apr 2012 15:25:43 +0300, Mika Westerberg <mika.westerberg@linux.intel.com> wrote:
> On 32-bit machines reading the /sys/kernel/debug/irq_domain_mapping file
> outputs following:
>
> virq hwirq chip name chip data domain name
> 9 0x00000 IO-APIC 0x c175a0f8 none
> 10 0x00000 IO-APIC 0x c175a108 none
> 11 0x00000 IO-APIC 0x c175a118 none
> ...
>
> which looks a bit funny. Fix that with filling the gap with zeroes instead
> of spaces.
>
> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Applied, thanks.
g.
> ---
> kernel/irq/irqdomain.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c
> index 3601f3f..d350c72 100644
> --- a/kernel/irq/irqdomain.c
> +++ b/kernel/irq/irqdomain.c
> @@ -666,7 +666,7 @@ static int virq_debug_show(struct seq_file *m, void *private)
> seq_printf(m, "%-15s ", p);
>
> data = irq_desc_get_chip_data(desc);
> - seq_printf(m, "0x%16p ", data);
> + seq_printf(m, "0x%016lx ", (unsigned long)data);
>
> if (desc->irq_data.domain && desc->irq_data.domain->of_node)
> p = desc->irq_data.domain->of_node->full_name;
> --
> 1.7.9.1
>
--
Grant Likely, B.Sc, P.Eng.
Secret Lab Technologies,Ltd.
next prev parent reply other threads:[~2012-04-10 23:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-10 12:25 [PATCH 1/2] irq_domain: correct the debugfs file name Mika Westerberg
2012-04-10 12:25 ` [PATCH 2/2] irq_domain: fix formatting of chip data pointer in virq_debug_show() Mika Westerberg
2012-04-10 23:27 ` Grant Likely [this message]
2012-04-11 5:47 ` Grant Likely
2012-04-11 9:21 ` Mika Westerberg
2012-04-10 23:26 ` [PATCH 1/2] irq_domain: correct the debugfs file name Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120410232708.CAC3D3E079B@localhost \
--to=grant.likely@secretlab.ca \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox