From: Oleg Nesterov <oleg@redhat.com>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
David Howells <dhowells@redhat.com>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] creds: kill __task_cred()->task_is_dead() validation
Date: Wed, 11 Apr 2012 20:52:52 +0200 [thread overview]
Message-ID: <20120411185252.GC22543@redhat.com> (raw)
In-Reply-To: <m1obqyh960.fsf@fess.ebiederm.org>
On 04/11, Eric W. Biederman wrote:
>
> Oleg Nesterov <oleg@redhat.com> writes:
>
> A small nit. The subject should be:
> "Remove task_is_dead from __task_cred() validation."
> there is no method __task_cred()->task_is_dead().
I often use this notation to show the caller and the callee,
but I don't really mind.
> > Unfortunately, we can't kill task_is_dead() right now, it has already
> > found the bugy users in drivers/staging/, the fix already exists.
>
> I would say task_is_dead() has already acquired buggy users in
> drivers/staging.
Argh, it least I shouldn't have said "bugy".
> As for the patch itself, and the direction of removing task_is_dead().
> It looks good from where I sit.
>
> Reviewed-by: "Eric W. Biederman" <ebiederm@xmission.com>
Thanks! I'll fix the subject/changelog and resend with your and
David's acks.
Oleg.
next prev parent reply other threads:[~2012-04-11 18:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-10 19:45 [PATCH 0/1] 3rd resend: kill __task_cred()->task_is_dead() Oleg Nesterov
2012-04-10 19:46 ` [PATCH 1/1] creds: kill __task_cred()->task_is_dead() validation Oleg Nesterov
2012-04-11 10:09 ` Eric W. Biederman
2012-04-11 18:52 ` Oleg Nesterov [this message]
2012-04-11 10:41 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120411185252.GC22543@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).