Re: [PATCH] block: mtip32xx: remove HOTPLUG_PCI_PCIE dependancy

[Greg KH <gregkh@linuxfoundation.org>]

On Wed, Apr 11, 2012 at 05:32:15PM -0700, Asai Thambi S P wrote:
> On 4/11/2012 3:37 PM, Greg KH wrote:
> 
> > On Wed, Apr 11, 2012 at 03:22:56PM -0700, Asai Thambi S P wrote:
> >> On 4/11/2012 1:40 PM, Greg KH wrote:
> >>
> >>> On Wed, Apr 11, 2012 at 01:33:39PM -0700, Asai Thambi S P wrote:
> >>>> On 4/11/2012 12:57 PM, Jens Axboe wrote:
> >>>>
> >>>>> On 2012-04-11 20:34, Greg KH wrote:
> >>>>>> This removes the HOTPLUG_PCI_PCIE dependency on the driver and makes it
> >>>>>> depend on PCI.
> >>>>>
> >>>>> I think it's an old dependency. I've built and run it here without as
> >>>>> well, and no functional issues either.
> >>>>>
> >>>>> Sam/Asai?
> >>>>>
> >>>>
> >>>>
> >>>> Both driver and device will work fine without PCIe hotplug dependency. This
> >>>> dependency is required for supporting surprise removal and surprise insertion
> >>>> of the device on systems with PCIe hotplug controller.
> >>>
> >>> But that's not a driver-specific thing at all.  All PCI drivers need to
> >>> be able to handle this (I like how you constantly check the pci id,
> >>> that's cute.)
> >>>
> >>> So I think a basic dependancy on PCI should be fine here.
> >>
> >> The P320 is different from existing PCIe devices supporting surprise removal
> >> and surprise insertion (SRSI) capability (aka hotplug). We equate the hotplug
> >> functionality enabled by PCIe hotplug controllers to that of any other storage
> >> endpoint (SAS, SATA, FC, etc). For those devices, hotplug functionality is
> >> enabled by the transport layer and propagated up to host storage stack for
> >> handling.
> > 
> > Huh?  No, hotplug on Linux happens on the PCI level, and has done so for
> > over 10 years.
> 
> Just to clarify, I was referring to hotplug of SAS/SATA/FC storage devices,
> not HBA.

Ah, ok, yes, you are right, but as you aren't using the SCSI layer here
(odd, but ok), you can only handle hotplug at the PCI layer.

thanks,

greg k-h