From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761791Ab2DLCbt (ORCPT ); Wed, 11 Apr 2012 22:31:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:29941 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752942Ab2DLCbr (ORCPT ); Wed, 11 Apr 2012 22:31:47 -0400 Date: Wed, 11 Apr 2012 22:31:32 -0400 From: Dave Jones To: Linux Kernel Cc: laijs@cn.fujitsu.com, fweisbec@gmail.com, srostedt@redhat.com, mingo@elte.hu Subject: remove unnecessary ftrace WARN_ONCE's. Message-ID: <20120412023132.GA7035@redhat.com> Mail-Followup-To: Dave Jones , Linux Kernel , laijs@cn.fujitsu.com, fweisbec@gmail.com, srostedt@redhat.com, mingo@elte.hu MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org These warnings are trivially triggerable by any user, and serve no useful purpose afaics Just -EINVAL and be done. Signed-off-by: Dave Jones diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c index ed7b5d1..a745317 100644 --- a/kernel/trace/trace.c +++ b/kernel/trace/trace.c @@ -4136,13 +4136,11 @@ tracing_buffers_splice_read(struct file *file, loff_t *ppos, return -ENOMEM; if (*ppos & (PAGE_SIZE - 1)) { - WARN_ONCE(1, "Ftrace: previous read must page-align\n"); ret = -EINVAL; goto out; } if (len & (PAGE_SIZE - 1)) { - WARN_ONCE(1, "Ftrace: splice_read should page-align\n"); if (len < PAGE_SIZE) { ret = -EINVAL; goto out;