From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: "Shankarmurthy, Akshay" <akshay.s@ti.com>
Cc: "linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
"alan@linux.intel.com" <alan@linux.intel.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"paul.gortmaker@windriver.com" <paul.gortmaker@windriver.com>,
"jamie@jamieiles.com" <jamie@jamieiles.com>,
"swarren@nvidia.com" <swarren@nvidia.com>,
"dianders@chromium.org" <dianders@chromium.org>,
"davinci-linux-open-source@linux.davincidsp.com"
<davinci-linux-open-source@linux.davincidsp.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] serial: 8250: Add cpufreq support
Date: Thu, 12 Apr 2012 10:47:58 +0100 [thread overview]
Message-ID: <20120412104758.3fc8085d@pyramind.ukuu.org.uk> (raw)
In-Reply-To: <6F6B80BD2E18844D97BB4B51FE3705C83179146B@DBDE01.ent.ti.com>
> > > I will have a look at this and add the lock if necessary.
> >
> > At the very least you need reference counts held on the tty struct and to allow for the tty having vanished under you.
> >
>
> I am planning to add "tty->termios_mutex" lock. Any comments ?
Explain how this will help. You need a reference count to the tty itself.
> I understand this and planning to avoid unnecessary registration like these.
> As a solution, UART port's cpu freq status will be sent from the board file.
> Adding a member to the structure "plat_serial8250_port" which says whether
> a port requires cpu freq registration or not. cpu freq register function is
> called in the driver depending upon the status of this structure member.
> I can update the patch accordingly and send out a version 2 to the list.
That sounds sensible.
Alan
next prev parent reply other threads:[~2012-04-12 9:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-03 6:03 [PATCH] serial: 8250: Add cpufreq support Shankarmurthy, Akshay
2012-04-03 9:55 ` Alan Cox
2012-04-05 10:40 ` Shankarmurthy, Akshay
2012-04-05 10:53 ` Alan Cox
2012-04-12 5:21 ` Shankarmurthy, Akshay
2012-04-12 9:47 ` Alan Cox [this message]
2012-04-17 9:43 ` Shankarmurthy, Akshay
2012-04-18 19:47 ` Alan Cox
-- strict thread matches above, loose matches on Subject: below --
2010-01-13 12:35 Chaithrika U S
2010-01-13 13:44 ` Alan Cox
2010-01-18 13:17 ` Chaithrika U S
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120412104758.3fc8085d@pyramind.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akshay.s@ti.com \
--cc=alan@linux.intel.com \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=dianders@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=jamie@jamieiles.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=swarren@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox