Re: [PATCH 00/13] KVM: MMU: fast page fault

Avi Kivity
2012-04-10T10:10:41Z

On 04/09/2012 09:26 PM, Xiao Guangrong wrote:
> Yes, if Xwindow is not enabled, the benefit is limited. :)

I'm more interested in migration.

We could optimize the framebuffer by disabling dirty logging when
VNC/Spice is not connected (which should usually be the case), or when
the SDL window is minimized (shouldn't be that often, unfortunately)

Related, qxl doesn't seem to stop the dirty log when switching to
accelerated mode. vmsvga gets it right:

case SVGA_REG_ENABLE:
s->enable = value;
s->config &= !!value;
s->width = -1;
s->height = -1;
s->invalidated = 1;
s->vga.invalidate(&s->vga);
if (s->enable) {
s->fb_size = ((s->depth + 7) >> 3) * s->new_width *
s->new_height;
vga_dirty_log_stop(&s->vga);
} else {
vga_dirty_log_start(&s->vga);
}
break;

--
error compiling committee.c: too many arguments to function