Re: [PATCH 05/13] KVM: MMU: reset shadow_mmio_mask

Avi Kivity
2012-03-29T16:25:19Z

On 03/29/2012 05:28 PM, Avi Kivity wrote:
> On 03/29/2012 03:10 PM, Avi Kivity wrote:
> > On 03/29/2012 11:23 AM, Xiao Guangrong wrote:
> > > Do not use the last byte (bit 56 ~ bit 63) in shadow_mmio_mask, the late
> > > patch will store vcpu id in the last byte
> >
> > Bit 63 is PT64_NX_MASK.
>
> Oh, you did say that with softmmu we're limited to 127 cpus. But what
> if spte.nx is changed while we update the identity?

Ok, saw that too. But I think test_and_set_bit() is better here, to
reduce the complexity (note we need cmpxchg64b on 32-bit instead).

--
error compiling committee.c: too many arguments to function