From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: "Ying-Chun Liu (PaulLiu)" <paul.liu@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linaro-dev@lists.linaro.org,
patches@linaro.org, Samuel Ortiz <sameo@linux.intel.com>,
Shawn Guo <shawn.guo@linaro.org>,
Ashish Jangam <ashish.jangam@kpitcummins.com>
Subject: Re: [PATCH v2 1/2] mfd: da9052: add device-tree support for i2c driver
Date: Fri, 13 Apr 2012 15:32:43 +0100 [thread overview]
Message-ID: <20120413143243.GW3168@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1334324261-5476-1-git-send-email-paul.liu@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 543 bytes --]
On Fri, Apr 13, 2012 at 09:37:40PM +0800, Ying-Chun Liu (PaulLiu) wrote:
> + regulators {
> + buck0 {
> + regulator-name = "DA9052_BUCK_CORE";
> + regulator-min-microvolt = <500000>;
> + regulator-max-microvolt = <2075000>;
> + };
This is more of a nit but these names look like they aren't terribly
idiomatic and could just be omitted - normally the name is used to tie
the name to the supply on the schematic so the above might be "VCORE" or
something. If no name is provided then whatever the driver provides
will be used.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2012-04-13 14:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-13 13:37 [PATCH v2 1/2] mfd: da9052: add device-tree support for i2c driver Ying-Chun Liu (PaulLiu)
2012-04-13 13:37 ` [PATCH v2 2/2] regulator: da9052: add device tree support Ying-Chun Liu (PaulLiu)
2012-04-13 14:56 ` Mark Brown
2012-04-13 14:32 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120413143243.GW3168@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=ashish.jangam@kpitcummins.com \
--cc=linaro-dev@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@linaro.org \
--cc=paul.liu@linaro.org \
--cc=sameo@linux.intel.com \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox