From: Oleg Nesterov <oleg@redhat.com>
To: Serge Hallyn <serge.hallyn@canonical.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Daniel Lezcano <daniel.lezcano@free.fr>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pidns: reboot_pid_ns: use SEND_SIG_FORCED instead of force_sig()
Date: Fri, 13 Apr 2012 21:24:55 +0200 [thread overview]
Message-ID: <20120413192455.GA24464@redhat.com> (raw)
In-Reply-To: <20120413182051.GA11149@sergelap>
Hi Serge,
On 04/13, Serge Hallyn wrote:
>
> Quoting Oleg Nesterov (oleg@redhat.com):
> > cf3f8921 "pidns: add reboot_pid_ns() to handle the reboot syscall"
> > uses force_sig() to kill the SIGNAL_UNKILLABLE cinit, this was the
> > only choice.
> >
> > After 629d362b we can use SEND_SIG_FORCED instead, force_sig() has
> > the special semantics and should be avoided if possible.
> >
> > Signed-off-by: Oleg Nesterov <oleg@redhat.com>
>
> Hi Oleg,
>
> I like the patch in theory, however after applying it containers are
> no longer able to shutdown/reboot. I can externally kill them with
> lxc-stop, but internal shutdown fails.
Oh, thanks a lot for testing.
Strange... I even tested this change, but only in the root namespace.
OK, thanks, I'll investigate. I hope you verified your kernel has
629d362b commit ;)
Oleg.
next prev parent reply other threads:[~2012-04-13 19:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-13 0:44 [PATCH] pidns: reboot_pid_ns: use SEND_SIG_FORCED instead of force_sig() Oleg Nesterov
2012-04-13 18:20 ` Serge Hallyn
2012-04-13 19:24 ` Oleg Nesterov [this message]
2012-04-13 19:34 ` Serge Hallyn
2012-04-16 13:59 ` Serge Hallyn
2012-04-16 15:38 ` Oleg Nesterov
2012-04-16 16:24 ` Serge Hallyn
2012-04-16 21:26 ` Oleg Nesterov
2012-04-17 18:35 ` Oleg Nesterov
2012-04-18 2:29 ` Serge E. Hallyn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120413192455.GA24464@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=daniel.lezcano@free.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=serge.hallyn@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox