From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756799Ab2DMUox (ORCPT ); Fri, 13 Apr 2012 16:44:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:18228 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755981Ab2DMUow (ORCPT ); Fri, 13 Apr 2012 16:44:52 -0400 Date: Fri, 13 Apr 2012 16:44:46 -0400 From: Vivek Goyal To: Tejun Heo Cc: axboe@kernel.dk, ctalbott@google.com, rni@google.com, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, containers@lists.linux-foundation.org Subject: Re: [PATCH 07/11] blkcg: make request_queue bypassing on allocation Message-ID: <20120413204446.GK26383@redhat.com> References: <1334347895-6268-1-git-send-email-tj@kernel.org> <1334347895-6268-8-git-send-email-tj@kernel.org> <20120413203205.GI26383@redhat.com> <20120413203726.GE12233@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120413203726.GE12233@google.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 13, 2012 at 01:37:26PM -0700, Tejun Heo wrote: [..] > blk_cleanup_queue() doesn't use blk_queue_bypass_start() to enter > bypass mode. Oh now elevator_exit() has been moved into blk_release_queue(). But problem will still be there, isn't it? During driver init, most likely driver is holding last reference of the queue and blk_release_queue() will be called in the context of blk_cleanup_queue() causing the overhead? Thanks Vivek