From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754251Ab2DMVgx (ORCPT ); Fri, 13 Apr 2012 17:36:53 -0400 Received: from mail-yw0-f46.google.com ([209.85.213.46]:50772 "EHLO mail-yw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752054Ab2DMVgv (ORCPT ); Fri, 13 Apr 2012 17:36:51 -0400 Date: Fri, 13 Apr 2012 18:36:44 -0300 From: Gustavo Padovan To: Jesper Juhl Cc: linux-kernel@vger.kernel.org, trivial@kernel.org, linux-bluetooth@vger.kernel.org, Johan Hedberg , Marcel Holtmann Subject: Re: [PATCH 01/26] Bluetooth: btmrvl_sdio: remove pointless conditional before release_firmware() Message-ID: <20120413213628.GA1680@joana> Mail-Followup-To: Gustavo Padovan , Jesper Juhl , linux-kernel@vger.kernel.org, trivial@kernel.org, linux-bluetooth@vger.kernel.org, Johan Hedberg , Marcel Holtmann References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jesper, * Jesper Juhl [2012-04-09 22:49:49 +0200]: > release_firmware() deals gracefullt with NULL pointers so there's no > reason to test for one prior to calling the function. > > Signed-off-by: Jesper Juhl > --- > drivers/bluetooth/btmrvl_sdio.c | 9 ++------- > 1 file changed, 2 insertions(+), 7 deletions(-) Patch has been applied, thanks. Gustavo