From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752977Ab2DNBE3 (ORCPT ); Fri, 13 Apr 2012 21:04:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43980 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751324Ab2DNBE1 (ORCPT ); Fri, 13 Apr 2012 21:04:27 -0400 Date: Fri, 13 Apr 2012 22:04:11 -0300 From: Arnaldo Carvalho de Melo To: Linus Torvalds Cc: mingo@kernel.org, hpa@zytor.com, paulus@samba.org, eranian@google.com, linux-kernel@vger.kernel.org, efault@gmx.de, peterz@infradead.org, namhyung@gmail.com, fweisbec@gmail.com, dsahern@gmail.com, Masami Hiramatsu , tglx@linutronix.de, linux-tip-commits@vger.kernel.org Subject: Re: [tip:perf/core] perf ui annotate browser: Allow toggling addr offset view Message-ID: <20120414010410.GB22114@infradead.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.20 (2009-12-10) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Fri, Apr 13, 2012 at 11:30:52AM -0700, Linus Torvalds escreveu: > On Fri, Apr 13, 2012 at 11:25 AM, Linus Torvalds > wrote: > > > > : > >    1.91 :          push   %rbp > > Oh, btw, talking about kmem_cache_free: that one uses altinstructions, > and so perf report shows the hottest instruction wrong (and I'm not > talking about "ugly"): Well, if we use Masami's disassembler we would use the actual code as it is being used and not the original DSO that was later patched by altinstructions. We would have to dump it somehow in the ~/.debug/ cache so that we could do offsite analysis, etc. My plan is to move the objdump_line stuff to something that doesn't have objdump in its name, i.e. something that would be generated by disassembler sources. The only now being binutils' objdump, but also Masami's disassembler and probably elfutils eu-objdump after it implements a disassembler + adds support for -debuginfo files, something that is needed to support userspace with source code intermixed. > 12.38 : ffffffff810d7ee5: lea (%r8),%rsi > 0.71 : ffffffff810d7ee8: callq ffffffff812d3df0 > > > that "lea" really isn't very expensive. In reality, it's not > "lea+call", it's a "lock ; cmpxchg16b + setz" instruction. But "perf" > doesn't know about alternative instructions, and if somebody were to > try to teach it, that would be lovely. > > Happily, x86-64 doesn't have quite as many of them as x86-32 does. But > they are there, sometimes in interesting functions. > Linus