From: Arnd Bergmann <arnd@arndb.de>
To: Lubos Lunak <l.lunak@suse.cz>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][RESEND] do not redefine userspace's NULL #define
Date: Sat, 14 Apr 2012 08:28:48 +0000 [thread overview]
Message-ID: <201204140828.49048.arnd@arndb.de> (raw)
In-Reply-To: <201204132346.57019.l.lunak@suse.cz>
On Friday 13 April 2012, Lubos Lunak wrote:
> If that were the case, one of the earlier versions of the patch would have
> been correct then, but as Arnd has pointed out, user applications do include
> the header. It's even as simple as:
>
> #include <signal.h>
>
> ( -> bits/sigcontext.h -> asm/sigcontext.h -> linux/types.h ->
> linux/posix_types.h -> linux/stddef.h ).
>
I knew there must have been something wrong with my thinking and I
clearly missed the posix_types.h reference. I accidentally did
'git grep linux/stddef.h obj/usr/include', instead of 'grep -r'.
I've tried to be more thorough this time, and I think that nothing
stops us from removing the linux/stddef.h include from the exported
version of posix_types.h, but we should probably make sure that we
still include linux/compiler.h, because a lot of stuff that includes
linux/posix_types.h expects that. Alternatively, we can just move the
NULL definition inside of #ifdef __KERNEL__.
Arnd
next prev parent reply other threads:[~2012-04-14 8:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-13 19:24 [PATCH][RESEND] do not redefine userspace's NULL #define Lubos Lunak
2012-04-13 19:39 ` Linus Torvalds
2012-04-13 21:02 ` Arnd Bergmann
2012-04-16 7:43 ` Martin Schwidefsky
2012-04-13 21:46 ` Lubos Lunak
2012-04-14 8:28 ` Arnd Bergmann [this message]
2012-04-13 22:01 ` Peter Seebach
2012-04-13 22:24 ` Linus Torvalds
2012-04-13 23:18 ` Lubos Lunak
2012-04-14 0:44 ` Linus Torvalds
2012-04-14 6:43 ` Lubos Lunak
2012-04-14 7:51 ` Linus Torvalds
2012-04-14 8:21 ` Lubos Lunak
2012-04-14 8:27 ` Linus Torvalds
2012-04-14 8:54 ` Lubos Lunak
2012-04-14 9:30 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201204140828.49048.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=akpm@linux-foundation.org \
--cc=l.lunak@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox