From: Gleb Natapov <gleb@redhat.com>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: acme@ghostprotocols.net, mingo@redhat.com, jolsa@redhat.com,
linux-kernel@vger.kernel.org, avi@redhat.com
Subject: Re: [PATCH] perf tools: Add 'G' and 'H' modifiers to event parsing
Date: Sun, 15 Apr 2012 18:23:00 +0300 [thread overview]
Message-ID: <20120415152300.GL11918@redhat.com> (raw)
In-Reply-To: <1334502742.28150.13.camel@twins>
On Sun, Apr 15, 2012 at 05:12:22PM +0200, Peter Zijlstra wrote:
> On Sun, 2012-04-15 at 17:59 +0300, Gleb Natapov wrote:
> > -modifier_event [ukhp]{1,5}
> > +modifier_event [ukhpGH]{1,5}
>
> You'd also need to increase the 5 to 7 I think, unless there's a clear
> exclusion with some of the other flags.
>
> Hmm, as it stands I think the 5 is already too low: "ukhppp" is 6.
>
> We should really write this as ['u'] ['k'] ['h'] ['G'] ['H'] ['p'{1,3}],
> not the combined thing.
If we will write them like that they all will have to be present for
successful match of modifier_event, no?
--
Gleb.
next prev parent reply other threads:[~2012-04-15 15:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-15 14:59 [PATCH] perf tools: Add 'G' and 'H' modifiers to event parsing Gleb Natapov
2012-04-15 15:12 ` Peter Zijlstra
2012-04-15 15:23 ` Gleb Natapov [this message]
2012-04-16 20:10 ` Jiri Olsa
2012-04-17 9:37 ` Gleb Natapov
2012-04-17 9:44 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120415152300.GL11918@redhat.com \
--to=gleb@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=avi@redhat.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox