From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753608Ab2DPNIY (ORCPT <rfc822;w@1wt.eu>);
	Mon, 16 Apr 2012 09:08:24 -0400
Received: from mx1.redhat.com ([209.132.183.28]:55074 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753247Ab2DPNIX (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 16 Apr 2012 09:08:23 -0400
Date: Mon, 16 Apr 2012 16:08:06 +0300
From: Gleb Natapov <gleb@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Sasha Levin <levinsasha928@gmail.com>, Avi Kivity <avi@redhat.com>,
        Marcelo Tosatti <mtosatti@redhat.com>,
        Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
        "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
        kvm <kvm@vger.kernel.org>, linux-kernel <linux-kernel@vger.kernel.org>,
        Dave Jones <davej@redhat.com>
Subject: Re: kvm: RCU warning in async pf
Message-ID: <20120416130806.GV11918@redhat.com>
References: <1333414472.11455.7.camel@lappy>
 <20120403105226.GF14939@redhat.com>
 <20120404123033.GD11918@redhat.com>
 <1334396693.2528.45.camel@twins>
 <20120416102855.GP11918@redhat.com>
 <20120416125848.GT11918@redhat.com>
 <1334581548.28150.40.camel@twins>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1334581548.28150.40.camel@twins>
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Apr 16, 2012 at 03:05:48PM +0200, Peter Zijlstra wrote:
> On Mon, 2012-04-16 at 15:58 +0300, Gleb Natapov wrote:
> > -               rcu_irq_enter();
> > +               irq_enter();
> >                 exit_idle(); 
> 
> Do we really need the exit_idle()? I can't remember other interrupt
> handlers doing that.
They do. That's where I got the idea.

--
			Gleb.