From: Jason Baron <jbaron@redhat.com>
To: Johannes Stezenbach <js@sig21.net>
Cc: Alan Stern <stern@rowland.harvard.edu>,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: ehci dynamic debug problem
Date: Mon, 16 Apr 2012 13:15:46 -0400 [thread overview]
Message-ID: <20120416171546.GD2345@redhat.com> (raw)
In-Reply-To: <20120416164139.GA14077@sig21.net>
On Mon, Apr 16, 2012 at 06:41:39PM +0200, Johannes Stezenbach wrote:
> On Mon, Apr 16, 2012 at 11:54:24AM -0400, Jason Baron wrote:
> > On Fri, Apr 13, 2012 at 09:03:11PM +0200, Johannes Stezenbach wrote:
> > >
> > > Does dynamic debug offer an "is the message two lines below enabled" test?
> > >
> >
> > Sorry was away for a bit...
> >
> > dynamic debug doesn't offer any is enabled test, its hidden from the
> > user. That said, in this case, you can delay the printing to the buffer
> > with:
> ...
> > + ehci_dbg (ehci, "%s\n", dbg_port_buf (_buf, sizeof _buf, label, port, status)); \
>
> I think arguments are evaluated before dev_dbg is called so this
> won't help.
>
>
I looked at the disassembly - and this argument was in fact *not* evaluated
before the call. So I think this approach is worthwhile.
Thanks,
-Jason
next prev parent reply other threads:[~2012-04-16 18:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-13 8:56 ehci dynamic debug problem Johannes Stezenbach
2012-04-13 14:35 ` Alan Stern
2012-04-13 14:57 ` Johannes Stezenbach
2012-04-13 15:19 ` Alan Stern
2012-04-13 17:41 ` Johannes Stezenbach
2012-04-13 18:13 ` Alan Stern
2012-04-13 19:03 ` Johannes Stezenbach
2012-04-13 19:40 ` Alan Stern
2012-04-16 15:11 ` Alan Stern
2012-04-16 15:54 ` Jason Baron
2012-04-16 16:41 ` Johannes Stezenbach
2012-04-16 17:15 ` Jason Baron [this message]
2012-04-16 19:07 ` Johannes Stezenbach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120416171546.GD2345@redhat.com \
--to=jbaron@redhat.com \
--cc=js@sig21.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox