From: Andrew Morton <akpm@linux-foundation.org>
To: Jason Baron <jbaron@redhat.com>
Cc: Yurij.Plotnikov@oktetlabs.ru, Alexandra.Kossovsky@oktetlabs.ru,
davidel@xmailserver.org, nelhage@nelhage.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] epoll: clear the tfile_check_list on -ELOOP
Date: Tue, 17 Apr 2012 14:13:15 -0700 [thread overview]
Message-ID: <20120417141315.703056a6.akpm@linux-foundation.org> (raw)
In-Reply-To: <201204171434.q3HEYqrq007242@int-mx09.intmail.prod.int.phx2.redhat.com>
On Tue, 17 Apr 2012 10:34:52 -0400
Jason Baron <jbaron@redhat.com> wrote:
> An epoll_ctl(,EPOLL_CTL_ADD,,) operation can return '-ELOOP' to prevent
> circular epoll dependencies from being created. However, in that case
> we do not properly clear the 'tfile_check_list'. Thus, add a call to
> clear_tfile_check_list() for the -ELOOP case.
So here I am wondering what effect this bug has upon our users, so I
can decide which kernel versions should be fixed. Jason didn't tell me
so I went to read the description of clear_tfile_check_list(). After a
brief chuckle, I stopped.
I then found Yurij's original report, so I know what's going on. But I
still can't write your changelog because I don't know whether this is a
regression and if it is, which patch caused the regression.
Wanna help out here please?
next prev parent reply other threads:[~2012-04-17 21:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-17 14:34 [PATCH] epoll: clear the tfile_check_list on -ELOOP Jason Baron
2012-04-17 21:13 ` Andrew Morton [this message]
2012-04-18 4:56 ` Alexandra N. Kossovsky
2012-04-19 15:34 ` Jason Baron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120417141315.703056a6.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=Alexandra.Kossovsky@oktetlabs.ru \
--cc=Yurij.Plotnikov@oktetlabs.ru \
--cc=davidel@xmailserver.org \
--cc=jbaron@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nelhage@nelhage.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox