* Re: [alsa-devel] [PATCH] ASoC: da7210: Minor update for PLL and SRM
[not found] <1334674858.13279.9.camel@matrix>
@ 2012-04-17 14:56 ` Mark Brown
[not found] ` <1334676602.13279.13.camel@matrix>
0 siblings, 1 reply; 2+ messages in thread
From: Mark Brown @ 2012-04-17 14:56 UTC (permalink / raw)
To: Ashish Chavan
Cc: lrg, alsa-devel, David Dajun Chen, kuninori.morimoto.gx,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 296 bytes --]
On Tue, Apr 17, 2012 at 08:30:58PM +0530, Ashish Chavan wrote:
> + if ((fref == da7210_pll_div[cnt].fref) &&
> + (da7210->master == da7210_pll_div[cnt].mode) &&
> + (fout == da7210_pll_div[cnt].fout)) {
Since this is just a coding style thing how about lining up the (s for
the branches?
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [alsa-devel] [PATCH] ASoC: da7210: Minor update for PLL and SRM
[not found] ` <1334676602.13279.13.camel@matrix>
@ 2012-04-17 15:20 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2012-04-17 15:20 UTC (permalink / raw)
To: Ashish Chavan
Cc: lrg, alsa-devel, David Dajun Chen, kuninori.morimoto.gx,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 425 bytes --]
On Tue, Apr 17, 2012 at 09:00:02PM +0530, Ashish Chavan wrote:
> To do that we will have to use spaces instead of tab for indentation. I
> am not sure if that is fine. You mean something like below, right?
> if ((fref == da7210_pll_div[cnt].fref) &&
> (da7210->master == da7210_pll_div[cnt].mode) &&
> (fout == da7210_pll_div[cnt].fout)) {
Yes, that's totally fine. 8 character tabs and spaces below that.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-04-17 15:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1334674858.13279.9.camel@matrix>
2012-04-17 14:56 ` [alsa-devel] [PATCH] ASoC: da7210: Minor update for PLL and SRM Mark Brown
[not found] ` <1334676602.13279.13.camel@matrix>
2012-04-17 15:20 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox