From: Samuel Ortiz <sameo@linux.intel.com>
To: Seth Heasley <seth.heasley@intel.com>
Cc: linux-kernel@vger.kernel.org, James Ralston <james.d.ralston@intel.com>
Subject: Re: [PATCH 3/3] lpc_sch: Add Intel Centerton Multifunction Device support
Date: Wed, 18 Apr 2012 12:18:02 +0200 [thread overview]
Message-ID: <20120418101802.GD1204@sortiz-mobl> (raw)
In-Reply-To: <1334696962-3642-1-git-send-email-seth.heasley@intel.com>
Hi Seth,
On Tue, Apr 17, 2012 at 02:09:22PM -0700, Seth Heasley wrote:
> This patch adds the Intel Centerton processor DeviceID for the Integrated Legacy Block. The ILB provides GPIO, SMBus, and Watchdog functionality. The ILB DeviceID is defined in include/linux/pci_ids.h.
>
Is the pci_ids.h change already in ? If not, I should take it at the same time
so that we don't break compilation.
> @@ -68,7 +69,7 @@ static struct resource wdt_sch_resource = {
>
> static struct mfd_cell tunnelcreek_cells[] = {
> {
> - .name = "tunnelcreek_wdt",
> + .name = "ie6xx_wdt",
> .num_resources = 1,
> .resources = &wdt_sch_resource,
> },
This one should be part of your upcoming watchdog driver patch (as a separate
patch that I'd take).
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
next prev parent reply other threads:[~2012-04-18 10:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-17 21:09 [PATCH 3/3] lpc_sch: Add Intel Centerton Multifunction Device support Seth Heasley
2012-04-18 10:18 ` Samuel Ortiz [this message]
2012-04-18 15:59 ` Heasley, Seth
2012-04-23 8:13 ` Samuel Ortiz
2012-04-23 18:34 ` Heasley, Seth
2012-05-09 14:01 ` Samuel Ortiz
2012-05-18 22:44 ` Grant Likely
2012-05-22 21:40 ` Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120418101802.GD1204@sortiz-mobl \
--to=sameo@linux.intel.com \
--cc=james.d.ralston@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=seth.heasley@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox