From: Andrew Morton <akpm@linux-foundation.org>
To: Venkatraman S <svenkatr@ti.com>
Cc: <linux-kernel@vger.kernel.org>, <santoshsy@gmail.com>,
<linkinjeon@gmail.com>,
James Bottomley <James.Bottomley@HansenPartnership.com>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH RESEND 2/2] scsi/ufs: Fix evaluation of task_failed status
Date: Wed, 18 Apr 2012 15:56:43 -0700 [thread overview]
Message-ID: <20120418155643.5b6eff01.akpm@linux-foundation.org> (raw)
In-Reply-To: <1334734733-13640-1-git-send-email-svenkatr@ti.com>
Please cc James and linux-scsi on drivers/scsi patches?
On Wed, 18 Apr 2012 13:08:53 +0530
Venkatraman S <svenkatr@ti.com> wrote:
> Else FAILED would be set even if task_result was
> originally equal to UPIU_TASK_MANAGEMENT_FUNC_SUCCEEDED.
This changelog is inadequate. It failed to describe the end-user
impact of the bug. Without this information we cannot decide which
kernel version(s) should be patched. Please always fully describe a
bug when fixing it.
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -1160,7 +1160,7 @@ static int ufshcd_task_req_compl(struct ufs_hba *hba, u32 index)
> task_result = be32_to_cpu(task_rsp_upiup->header.dword_1);
> task_result = ((task_result & MASK_TASK_RESPONSE) >> 8);
>
> - if (task_result != UPIU_TASK_MANAGEMENT_FUNC_COMPL ||
> + if (task_result != UPIU_TASK_MANAGEMENT_FUNC_COMPL &&
> task_result != UPIU_TASK_MANAGEMENT_FUNC_SUCCEEDED)
> task_result = FAILED;
> } else {
And the title of the patch is poor. There is no "task_failed" here.
Something like "fix evaluation of task completion code" would be
better?
next prev parent reply other threads:[~2012-04-18 22:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-18 7:38 [PATCH RESEND 2/2] scsi/ufs: Fix evaluation of task_failed status Venkatraman S
2012-04-18 22:56 ` Andrew Morton [this message]
2012-04-19 6:09 ` S, Venkatraman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120418155643.5b6eff01.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=linkinjeon@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=santoshsy@gmail.com \
--cc=svenkatr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox