From: Greg KH <greg@kroah.com>
To: Valentin Ilie <valentin.ilie@gmail.com>
Cc: arve@android.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: android: binder.c const char* smth TO const char * const smth
Date: Wed, 18 Apr 2012 16:48:27 -0700 [thread overview]
Message-ID: <20120418234827.GA2227@kroah.com> (raw)
In-Reply-To: <1334543494-13425-1-git-send-email-valentin.ilie@gmail.com>
On Mon, Apr 16, 2012 at 05:31:34AM +0300, Valentin Ilie wrote:
> Replaced static const char* var with static const char * var const smth because
> smth doesn't need to be reassigned at any point else at runtime.
"smth"? What is that?
>
> Signed-off-by: Valentin Ilie <valentin.ilie@gmail.com>
> ---
> drivers/staging/android/binder.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c
> index c283212..221bd3f 100644
> --- a/drivers/staging/android/binder.c
> +++ b/drivers/staging/android/binder.c
> @@ -3303,7 +3303,7 @@ static void print_binder_proc(struct seq_file *m,
> m->count = start_pos;
> }
>
> -static const char *binder_return_strings[] = {
> +static const char * const binder_return_strings[] = {
I don't understand, what's the advantage here? Why is this needed?
Does it save space? Speed? Compiler warnings?
I need a better reason to apply it other than a word with no vowels...
greg k-h
prev parent reply other threads:[~2012-04-18 23:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-16 2:31 [PATCH] Staging: android: binder.c const char* smth TO const char * const smth Valentin Ilie
2012-04-18 23:48 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120418234827.GA2227@kroah.com \
--to=greg@kroah.com \
--cc=arve@android.com \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=valentin.ilie@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox