From: Jesper Nilsson <jesper.nilsson@axis.com>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: Mikael Starvik <starvik@axis.com>,
linux-cris-kernel <linux-cris-kernel@axis.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-next@vger.kernel.org" <linux-next@vger.kernel.org>
Subject: Re: [PATCH] cris: Remove old legacy "-traditional" flag from arch-v10/lib/Makefile
Date: Thu, 19 Apr 2012 11:14:50 +0200 [thread overview]
Message-ID: <20120419091450.GF16861@axis.com> (raw)
In-Reply-To: <1334779123-21957-1-git-send-email-paul.gortmaker@windriver.com>
On Wed, Apr 18, 2012 at 09:58:43PM +0200, Paul Gortmaker wrote:
> Most of these have been purged years ago. This one silently lived
> on until commit 69349c2dc01c489eccaa4c472542c08e370c6d7e
>
> "kconfig: fix IS_ENABLED to not require all options to be defined"
>
> In the above, we use some macro trickery to create a conditional that
> is valid in CPP and in C usage. However that trickery doesn't sit
> well if you have the legacy "-traditional" flag enabled. You'll get:
>
> AS arch/cris/arch-v10/lib/checksum.o
> In file included from <command-line>:4:0:
> include/linux/kconfig.h:23:0: error: syntax error in macro parameter list
> make[2]: *** [arch/cris/arch-v10/lib/checksum.o] Error 1
>
> Everything builds fine w/o "-traditional" so simply drop it from this
> location as well.
>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Agreed, I'll push this to the CRIS-tree. Thanks!
/^JN - Jesper Nilsson
--
Jesper Nilsson -- jesper.nilsson@axis.com
next prev parent reply other threads:[~2012-04-19 9:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-18 19:58 [PATCH] cris: Remove old legacy "-traditional" flag from arch-v10/lib/Makefile Paul Gortmaker
2012-04-19 9:14 ` Jesper Nilsson [this message]
2012-04-19 12:40 ` Paul Gortmaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120419091450.GF16861@axis.com \
--to=jesper.nilsson@axis.com \
--cc=linux-cris-kernel@axis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=starvik@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox