From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: MyungJoo Ham <myungjoo.ham@samsung.com>
Cc: "Greg KH" <gregkh@linuxfoundation.org>,
"Arnd Bergmann" <arnd@arndb.de>,
LKML <linux-kernel@vger.kernel.org>, NeilBrown <neilb@suse.de>,
"Randy Dunlap" <rdunlap@xenotime.net>,
"Mike Lockwood" <lockwood@android.com>,
"Arve Hjønnevag" <arve@android.com>,
"Kyungmin Park" <kyungmin.park@samsung.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
"Morten CHRISTIANSEN" <morten.christiansen@stericsson.com>,
"John Stultz" <john.stultz@linaro.org>,
"Joerg Roedel" <joerg.roedel@amd.com>,
myungjoo.ham@gmail.com, cw00.choi@samsung.com
Subject: Re: [PATCH v8 1/6] Extcon (external connector): import Android's switch class and modify.
Date: Thu, 19 Apr 2012 12:38:19 +0100 [thread overview]
Message-ID: <20120419113818.GA3046@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1334803298-24260-2-git-send-email-myungjoo.ham@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 1092 bytes --]
On Thu, Apr 19, 2012 at 11:41:33AM +0900, MyungJoo Ham wrote:
> External connector class (extcon) is based on and an extension of
> Android kernel's switch class located at linux/drivers/switch/.
Reviewed-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> +comment "Extcon Class Configuration"
> +
> +config EXTCON_ANDROID_COMPATIBLE
> + bool "Class name uses 'switch' to be compatible with Android kernel"
> + depends on ANDROID
> + help
> + The class name of extcon device drivers are set 'switch' in order
> + to be compatible with Android kernel switch framework. With this
> + option enabled, Android userspace platform may use extcon device
> + drivers as if they are switch device drivers.
Though I think this is out of date now? Not a big deal and could be
fixed up later.
> +#if defined(CONFIG_ANDROID) && !defined(CONFIG_ANDROID_SWITCH)
> + switch_class = class_compat_register("switch");
> + if (WARN(!switch_class, "cannot allocate"))
> + return -ENOMEM;
> +#endif /* CONFIG_ANDROID && !defined(CONFIG_ANDROID_SWITCH) */
This does the above but differently.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-04-19 11:38 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-23 8:52 [PATCH v7 0/6] Introduce External Connector Class (extcon) MyungJoo Ham
2012-03-23 8:52 ` [PATCH v7 1/6] Extcon (external connector): import Android's switch class and modify MyungJoo Ham
2012-04-18 21:47 ` Greg KH
2012-04-18 23:38 ` Kyungmin Park
2012-04-18 23:40 ` Greg KH
2012-04-18 23:48 ` Kyungmin Park
2012-04-19 0:01 ` Greg KH
2012-04-19 2:36 ` MyungJoo Ham
2012-04-19 2:41 ` [PATCH v8 0/6] Introduce External Connector Class (extcon) MyungJoo Ham
2012-04-19 2:41 ` [PATCH v8 1/6] Extcon (external connector): import Android's switch class and modify MyungJoo Ham
2012-04-19 11:38 ` Mark Brown [this message]
2012-04-20 2:37 ` Greg KH
2012-04-20 2:46 ` Kyungmin Park
2012-04-20 2:49 ` Greg KH
2012-04-20 2:57 ` Kyungmin Park
2012-04-20 3:00 ` Greg KH
2012-04-20 3:08 ` Kyungmin Park
2012-04-20 3:32 ` Greg KH
2012-04-20 5:16 ` [PATCH v8 resend 0/6] Introduce External Connector Class (extcon) MyungJoo Ham
2012-04-20 5:16 ` [PATCH v8 resend 1/6] Extcon (external connector): import Android's switch class and modify MyungJoo Ham
2012-04-20 7:00 ` Ryan Mallon
2012-04-20 5:16 ` [PATCH v8 resend 2/6] Extcon: support generic GPIO extcon driver MyungJoo Ham
2012-04-20 5:16 ` [PATCH v8 resend 3/6] Extcon: support notification based on the state changes MyungJoo Ham
2012-04-20 5:16 ` [PATCH v8 resend 4/6] Extcon: support multiple states at a device MyungJoo Ham
2012-04-20 5:16 ` [PATCH v8 resend 5/6] Extcon: support mutually exclusive relation between cables MyungJoo Ham
2012-04-20 5:16 ` [PATCH v8 resend 6/6] Documentation/extcon: porting guide for Android kernel switch driver MyungJoo Ham
2012-04-20 16:25 ` Greg KH
2012-04-20 17:05 ` Mark Brown
2012-04-20 17:15 ` Greg KH
2012-04-20 21:59 ` Mark Brown
2012-04-20 16:27 ` [PATCH v8 resend 0/6] Introduce External Connector Class (extcon) Greg KH
2012-04-23 11:18 ` MyungJoo Ham
2012-04-23 11:19 ` [PATCH] Remove "switch" class in drivers/staging/android/switch MyungJoo Ham
2012-04-23 20:25 ` Greg KH
2012-04-19 2:41 ` [PATCH v8 2/6] Extcon: support generic GPIO extcon driver MyungJoo Ham
2012-04-19 11:40 ` Mark Brown
2012-04-19 2:41 ` [PATCH v8 3/6] Extcon: support notification based on the state changes MyungJoo Ham
2012-04-19 2:41 ` [PATCH v8 4/6] Extcon: support multiple states at a device MyungJoo Ham
2012-04-19 2:41 ` [PATCH v8 5/6] Extcon: support mutually exclusive relation between cables MyungJoo Ham
2012-04-19 2:41 ` [PATCH v8 6/6] Documentation/extcon: porting guide for Android kernel switch driver MyungJoo Ham
2012-03-23 8:52 ` [PATCH v7 2/6] Extcon: support generic GPIO extcon driver MyungJoo Ham
2012-03-23 8:53 ` [PATCH v7 3/6] Extcon: support notification based on the state changes MyungJoo Ham
2012-03-23 8:53 ` [PATCH v7 4/6] Extcon: support multiple states at a device MyungJoo Ham
2012-03-23 8:53 ` [PATCH v7 5/6] Extcon: support mutually exclusive relation between cables MyungJoo Ham
2012-03-23 8:53 ` [PATCH v7 6/6] Documentation/extcon: porting guide for Android kernel switch driver MyungJoo Ham
2012-03-23 8:53 ` [RFC PATCH] Remove "switch" class in drivers/staging/android/switch MyungJoo Ham
2012-03-28 9:39 ` [PATCH v7 0/6] Introduce External Connector Class (extcon) MyungJoo Ham
2012-03-28 14:44 ` Greg KH
2012-03-28 15:24 ` Arnd Bergmann
2012-03-28 15:28 ` Greg KH
2012-03-29 4:20 ` Kyungmin Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120419113818.GA3046@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=arnd@arndb.de \
--cc=arve@android.com \
--cc=cw00.choi@samsung.com \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=joerg.roedel@amd.com \
--cc=john.stultz@linaro.org \
--cc=kyungmin.park@samsung.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lockwood@android.com \
--cc=morten.christiansen@stericsson.com \
--cc=myungjoo.ham@gmail.com \
--cc=myungjoo.ham@samsung.com \
--cc=neilb@suse.de \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox