From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Lin Ming <mlin@ss.pku.edu.cn>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Steven Noonan <steven@uplinklabs.net>,
linux-kernel@vger.kernel.org,
Marcus Granado <marcus.granado@citrix.com>,
xen-devel@lists.xen.org, Ben Guthro <ben@guthro.net>
Subject: Re: [Xen-devel] [PATCH 2/2] xen: implement IRQ_WORK_VECTOR handler
Date: Thu, 19 Apr 2012 16:00:23 -0400 [thread overview]
Message-ID: <20120419200023.GD28211@phenom.dumpdata.com> (raw)
In-Reply-To: <CAF1ivSZ8H2jp6sv=F8DXBAG9Wi87zCLh5Lbh+aeN66eJg_F1_Q@mail.gmail.com>
> >> +static irqreturn_t xen_irq_work_interrupt(int irq, void *dev_id)
> >> +{
> >> + irq_enter();
> >> + inc_irq_stat(apic_irq_work_irqs);
> >> + irq_work_run();
> >
> > I think this usually done the other way around:
> >
> > irq_work_run()
> > inc_irq_stat(apic_irq_work_irqs)
> >
> > Or is there an excellent reason for doing it this way?
>
> Copy & paste from smp_irq_work_interrupt().
> But I think there is no much difference.
>
> Anyway, I can change it if needed.
Please do. It looks at odds with the other usages in this file.
prev parent reply other threads:[~2012-04-19 20:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-15 6:09 Lin Ming
2012-04-15 6:09 ` [PATCH 1/2] xen: implement apic ipi interface Lin Ming
2012-04-19 19:02 ` Konrad Rzeszutek Wilk
2012-04-19 19:11 ` Konrad Rzeszutek Wilk
2012-04-15 6:09 ` [PATCH 2/2] xen: implement IRQ_WORK_VECTOR handler Lin Ming
2012-04-16 20:32 ` Konrad Rzeszutek Wilk
2012-04-19 8:46 ` Lin Ming
2012-04-19 20:00 ` Konrad Rzeszutek Wilk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120419200023.GD28211@phenom.dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=a.p.zijlstra@chello.nl \
--cc=ben@guthro.net \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcus.granado@citrix.com \
--cc=mlin@ss.pku.edu.cn \
--cc=steven@uplinklabs.net \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox