From: Cyrill Gorcunov <gorcunov@openvz.org>
To: Oleg Nesterov <oleg@redhat.com>
Cc: akpm@linux-foundation.org, khlebnikov@openvz.org,
keescook@chromium.org, kosaki.motohiro@jp.fujitsu.com,
matthltc@us.ibm.com, tj@kernel.org, xemul@parallels.com,
linux-kernel@vger.kernel.org
Subject: Re: + c-r-prctl-add-ability-to-set-new-mm_struct-exe_file-update-after-mm- num_exe_file_vmas-removal.patch added to -mm tree
Date: Fri, 20 Apr 2012 01:00:33 +0400 [thread overview]
Message-ID: <20120419210033.GO1893@moon> (raw)
In-Reply-To: <20120419192005.GA13558@redhat.com>
On Thu, Apr 19, 2012 at 09:20:05PM +0200, Oleg Nesterov wrote:
> On 04/19, Andrew Morton wrote:
> >
> > From: Konstantin Khlebnikov <khlebnikov@openvz.org>
> > Subject: c/r: prctl: update prctl_set_mm_exe_file() after mm->num_exe_file_vmas removal
> >
> > [ fix for "c-r-prctl-add-ability-to-set-new-mm_struct-exe_file-v2" from mm tree ]
> >
> > After removing mm->num_exe_file_vmas kernel keeps mm->exe_file until final
> > mmput(), it never becomes NULL while task is alive.
> >
> > We can check for other mapped files in mm instead of checking
> > mm->num_exe_file_vmas, and mark mm with flag MMF_EXE_FILE_CHANGED in order
> > to forbid second changing of mm->exe_file.
>
> I lost the track a long ago.
>
> Just one question, what does this "forbid second changing" actually mean?
Heh :) Oleg, it was actually your idea to make this feature "one-shot".
Once exe-file changed to a new value, it can't be changed again. The
reason was to bring at least minimum disturbance in sysadmins life.
Cyrill
next prev parent reply other threads:[~2012-04-19 21:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20120419185221.E8ED6A055E@akpm.mtv.corp.google.com>
2012-04-19 19:20 ` + c-r-prctl-add-ability-to-set-new-mm_struct-exe_file-update-after-mm- num_exe_file_vmas-removal.patch added to -mm tree Oleg Nesterov
2012-04-19 21:00 ` Cyrill Gorcunov [this message]
2012-04-19 21:12 ` Oleg Nesterov
2012-04-19 21:32 ` Cyrill Gorcunov
2012-04-19 22:08 ` Konstantin Khlebnikov
2012-04-19 22:16 ` Cyrill Gorcunov
2012-04-19 22:29 ` Oleg Nesterov
2012-04-19 21:46 ` Konstantin Khlebnikov
2012-04-19 21:51 ` Oleg Nesterov
2012-04-19 22:02 ` Cyrill Gorcunov
2012-04-19 22:09 ` Oleg Nesterov
2012-04-19 22:28 ` Konstantin Khlebnikov
2012-04-19 22:32 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120419210033.GO1893@moon \
--to=gorcunov@openvz.org \
--cc=akpm@linux-foundation.org \
--cc=keescook@chromium.org \
--cc=khlebnikov@openvz.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matthltc@us.ibm.com \
--cc=oleg@redhat.com \
--cc=tj@kernel.org \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox