public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@amd64.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Borislav Petkov <bp@amd64.org>, "H. Peter Anvin" <hpa@zytor.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Ingo Molnar <mingo@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 3/3] x86, extable: Handle early exceptions
Date: Fri, 20 Apr 2012 10:46:47 +0200	[thread overview]
Message-ID: <20120420084647.GA3247@aftab.osrc.amd.com> (raw)
In-Reply-To: <CA+55aFywgsZsxRpYeY2TCHUuK6uRvp8fp8GZEVk50qNc=WS=dw@mail.gmail.com>

On Thu, Apr 19, 2012 at 11:11:00AM -0700, Linus Torvalds wrote:
> > OTOH, if we can share early and normal exception handling lookup code, then a
> > perfect hash would make sense as those exceptions would pile up.
> 
> Oh, any of this only makes sense if we can share it with the runtime
> exception lookup.
> 
> They are *seldom* hugely performance-critical, but there are some
> unusual loads where you do get a fair number of exceptions.

I was thinking, and this is probably purely hypothetical and tangential
to the topic but, what happens if we get an exception right in the
middle between using the early_idt_handler's and switching to the normal
trap handlers in trap_init()?

write_idt_entry() is a simple memcpy so what happens if we have a
half-written descriptor? Won't we need some locking there to atomize the
switch?

Or am I dreaming?

Thanks.

-- 
Regards/Gruss,
Boris.

Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
GM: Alberto Bozzo
Reg: Dornach, Landkreis Muenchen
HRB Nr. 43632 WEEE Registernr: 129 19551

  reply	other threads:[~2012-04-20  8:46 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-19  0:16 [PATCH 0/5] RFC: x86: Early exception table support H. Peter Anvin
2012-04-19  0:16 ` [PATCH 1/5] x86, nop: Make the ASM_NOP* macros work from assembly H. Peter Anvin
2012-04-19  9:29   ` Borislav Petkov
2012-04-20  0:24   ` [tip:x86/extable] " tip-bot for H. Peter Anvin
2012-04-19  0:16 ` [PATCH 2/5] x86: Add symbolic constant for exceptions with error code H. Peter Anvin
2012-04-19  9:30   ` Borislav Petkov
2012-04-20  0:25   ` [tip:x86/extable] " tip-bot for H. Peter Anvin
2012-04-19  0:16 ` [PATCH 3/5] x86, paravirt: Replace GET_CR2_INTO_RCX with GET_CR2_INTO_RAX H. Peter Anvin
2012-04-20  0:26   ` [tip:x86/extable] " tip-bot for H. Peter Anvin
2012-04-19  0:16 ` [PATCH 4/5] x86-64: Handle exception table entries during early boot H. Peter Anvin
2012-04-19 13:02   ` Borislav Petkov
2012-04-19 16:59     ` H. Peter Anvin
2012-04-19 17:16       ` Borislav Petkov
2012-04-20  0:29         ` [tip:x86/extable] x86, doc: Revert "x86: Document rdmsr_safe restrictions" tip-bot for H. Peter Anvin
2012-04-20  0:28   ` [tip:x86/extable] x86-64: Handle exception table entries during early boot tip-bot for H. Peter Anvin
2012-04-19  0:16 ` [PATCH 5/5] x86-32: " H. Peter Anvin
2012-04-20  0:28   ` [tip:x86/extable] " tip-bot for H. Peter Anvin
2012-04-19  9:22 ` [PATCH 0/5] RFC: x86: Early exception table support Borislav Petkov
2012-04-19  9:24   ` [PATCH 1/3] x86, extable: Cleanup fixup_exception Borislav Petkov
2012-04-19  9:25   ` [PATCH 2/3] x86, extable: Carve out the main extable searching routine Borislav Petkov
2012-04-19  9:26   ` [PATCH 3/3] x86, extable: Handle early exceptions Borislav Petkov
2012-04-19 17:02     ` H. Peter Anvin
2012-04-19 17:27       ` Linus Torvalds
2012-04-19 17:38         ` Borislav Petkov
2012-04-19 17:59           ` H. Peter Anvin
2012-04-19 18:25             ` Linus Torvalds
2012-04-19 18:55               ` H. Peter Anvin
2012-04-19 20:17                 ` David Daney
2012-04-19 20:20                   ` H. Peter Anvin
2012-04-19 20:26                     ` H. Peter Anvin
2012-04-19 20:40                       ` David Daney
2012-04-19 21:47                       ` Linus Torvalds
2012-04-19 22:16                   ` H. Peter Anvin
2012-04-19 22:47                     ` Tony Luck
2012-04-19 22:58                       ` Linus Torvalds
2012-04-19 23:10                         ` H. Peter Anvin
2012-04-19 23:26                           ` Tony Luck
2012-04-19 23:35                             ` H. Peter Anvin
2012-04-20  8:26                             ` Andreas Schwab
2012-04-19 18:11           ` Linus Torvalds
2012-04-20  8:46             ` Borislav Petkov [this message]
2012-04-19 17:54       ` H. Peter Anvin
2012-04-20  0:27 ` [tip:x86/extable] x86, extable: Add early_fixup_exception() tip-bot for H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120420084647.GA3247@aftab.osrc.amd.com \
    --to=bp@amd64.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox