From: Dave Jones <davej@redhat.com>
To: Linux Kernel <linux-kernel@vger.kernel.org>,
laijs@cn.fujitsu.com, fweisbec@gmail.com, srostedt@redhat.com,
mingo@elte.hu
Subject: Re: remove unnecessary ftrace WARN_ONCE's.
Date: Fri, 20 Apr 2012 13:03:56 -0400 [thread overview]
Message-ID: <20120420170356.GC2168@redhat.com> (raw)
In-Reply-To: <20120412023132.GA7035@redhat.com>
On Wed, Apr 11, 2012 at 10:31:32PM -0400, Dave Jones wrote:
> These warnings are trivially triggerable by any user, and serve no useful purpose afaics
> Just -EINVAL and be done.
>
> Signed-off-by: Dave Jones <davej@redhat.com>
>
> diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
> index ed7b5d1..a745317 100644
> --- a/kernel/trace/trace.c
> +++ b/kernel/trace/trace.c
> @@ -4136,13 +4136,11 @@ tracing_buffers_splice_read(struct file *file, loff_t *ppos,
> return -ENOMEM;
>
> if (*ppos & (PAGE_SIZE - 1)) {
> - WARN_ONCE(1, "Ftrace: previous read must page-align\n");
> ret = -EINVAL;
> goto out;
> }
>
> if (len & (PAGE_SIZE - 1)) {
> - WARN_ONCE(1, "Ftrace: splice_read should page-align\n");
> if (len < PAGE_SIZE) {
> ret = -EINVAL;
> goto out;
> --
Anyone want to pick this up, or shall I just send it to Linus myself ?
Dave
next prev parent reply other threads:[~2012-04-20 17:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-12 2:31 remove unnecessary ftrace WARN_ONCE's Dave Jones
2012-04-20 17:03 ` Dave Jones [this message]
2012-04-20 18:11 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120420170356.GC2168@redhat.com \
--to=davej@redhat.com \
--cc=fweisbec@gmail.com \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=srostedt@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox