From: Dan Carpenter <dan.carpenter@oracle.com>
To: my84@bk.ru
Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, mchehab@infradead.org,
dhowells@redhat.com, justinmattock@gmail.com,
linux-media@vger.kernel.org
Subject: Re: [PATCH] [Trivial] staging: go7007: Framesizes features
Date: Sat, 21 Apr 2012 16:49:38 +0300 [thread overview]
Message-ID: <20120421134938.GT6498@mwanda> (raw)
In-Reply-To: <4f92b043.xYYL+7fcNMQk08OJ%my84@bk.ru>
On Sat, Apr 21, 2012 at 05:04:03PM +0400, my84@bk.ru wrote:
>
> Correct framesizes
>
> Signed-off-by Volokh Konstantin <my84@bk.ru>
>
Looks good. But could you write a proper changelog? What is the
effect for the user? How did you find these numbers? Have you
tested the changes? It should mention something about that this
affects boards with GO7007_SENSOR_TV.
Btw, how many boards are their that have a GO7007_SENSOR_TV but
don't have a GO7007_BOARD_HAS_TUNER? Should the comment be updated?
The changelog says it "Correct framesizes" but it doesn't actually
correct anything, it just adds new features that weren't supported
before.
Don't put [Trivial] in the subject line. Trivial patches are things
like spelling mistakes in comments.
regards,
dan carpenter
next prev parent reply other threads:[~2012-04-21 13:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-21 13:04 [PATCH] [Trivial] staging: go7007: Framesizes features my84
2012-04-21 13:49 ` Dan Carpenter [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-04-24 15:03 volokh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120421134938.GT6498@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=dhowells@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=justinmattock@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=my84@bk.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox