From: Dan Carpenter <dan.carpenter@oracle.com>
To: Jesper Juhl <jj@chaosbits.net>
Cc: linux-kernel@vger.kernel.org,
Valentin Rothberg <valentinrothberg@googlemail.com>,
devel@driverdev.osuosl.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jon Nettleton <jon.nettleton@gmail.com>,
Wolfram Sang <w.sang@pengutronix.de>,
Jordan Crouse <jordan@cosmicpenguin.net>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
Andres Salomon <dilinger@queued.net>, Chris Ball <cjb@laptop.org>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH 3/3] staging: olpc_dcon.c: Remove a few spaces between casts and variables
Date: Sat, 21 Apr 2012 23:28:25 +0300 [thread overview]
Message-ID: <20120421202825.GW6498@mwanda> (raw)
In-Reply-To: <alpine.LNX.2.00.1204212031360.25551@swampdragon.chaosbits.net>
On Sat, Apr 21, 2012 at 08:33:15PM +0200, Jesper Juhl wrote:
> Just a trivial style cleanup.
>
> Signed-off-by: Jesper Juhl <jj@chaosbits.net>
> ---
> drivers/staging/olpc_dcon/olpc_dcon.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/olpc_dcon/olpc_dcon.c b/drivers/staging/olpc_dcon/olpc_dcon.c
> index 7fe6eb6..992275c 100644
> --- a/drivers/staging/olpc_dcon/olpc_dcon.c
> +++ b/drivers/staging/olpc_dcon/olpc_dcon.c
> @@ -134,7 +134,7 @@ static int dcon_bus_stabilize(struct dcon_priv *dcon, int is_powered_down)
> power_up:
> if (is_powered_down) {
> x = 1;
> - x = olpc_ec_cmd(0x26, (unsigned char *) &x, 1, NULL, 0);
> + x = olpc_ec_cmd(0x26, (unsigned char *)&x, 1, NULL, 0);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
This will only work on little endian systems btw. On big endian
systems the first byte is going to be 0x00 instead of 0x01.
> if (x) {
> printk(KERN_WARNING "olpc-dcon: unable to force dcon to power up: %d!\n",
> x);
regards,
dan carpenter
next prev parent reply other threads:[~2012-04-21 20:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-21 18:32 [PATCH 0/3] staging: olpc_dcon.c: checkpatch.pl and style fixups Jesper Juhl
2012-04-21 18:32 ` [PATCH 1/3] staging: olpc_dcon.c: strings printed with printk() put on a single line Jesper Juhl
2012-04-21 18:33 ` [PATCH 2/3] staging: olpc_dcon.c: Add missing level to a printk() Jesper Juhl
2012-04-21 18:33 ` [PATCH 3/3] staging: olpc_dcon.c: Remove a few spaces between casts and variables Jesper Juhl
2012-04-21 20:28 ` Dan Carpenter [this message]
2012-04-21 20:41 ` Jesper Juhl
2012-04-21 22:13 ` Dan Carpenter
2012-04-21 23:15 ` [PATCH 0/3] staging: olpc_dcon.c: checkpatch.pl and style fixups Andres Salomon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120421202825.GW6498@mwanda \
--to=dan.carpenter@oracle.com \
--cc=cjb@laptop.org \
--cc=devel@driverdev.osuosl.org \
--cc=dilinger@queued.net \
--cc=dwmw2@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=jj@chaosbits.net \
--cc=jon.nettleton@gmail.com \
--cc=jordan@cosmicpenguin.net \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=valentinrothberg@googlemail.com \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox