Re: [PATCH 3/3] lpc_sch: Add Intel Centerton Multifunction Device support

[Samuel Ortiz <sameo@linux.intel.com>]

Hi Seth,

On Wed, Apr 18, 2012 at 03:59:49PM +0000, Heasley, Seth wrote:
> Hi Samuel,
> 
> >Is the pci_ids.h change already in ? If not, I should take it at the
> >same time so that we don't break compilation.
> 
> It was submitted just prior to my sending this patch.
Please send it to me as your MFD patch build depends on it and it should be
committed first.



> >> @@ -68,7 +69,7 @@ static struct resource wdt_sch_resource = {
> >>
> >>  static struct mfd_cell tunnelcreek_cells[] = {
> >>  	{
> >> -		.name = "tunnelcreek_wdt",
> >> +		.name = "ie6xx_wdt",
> >>  		.num_resources = 1,
> >>  		.resources = &wdt_sch_resource,
> >>  	},
> >This one should be part of your upcoming watchdog driver patch (as a
> >separate patch that I'd take).
> 
> I'm actually not submitting a watchdog patch.  The maintainer already has code for this driver and is converting it to the new watchdog API.  In discussions with him, we agreed to the renaming of the driver, which was submitted for a previous platform.  He'll be committing the new code in the next couple of weeks, so I made this change in anticipation of the driver making it upstream.
>
That's reasonable, but I'd prefer this naming change to happen when the
watchdog patch is submitted as well, as a separate MFD one liner patch.

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/