From: Felipe Balbi <balbi@ti.com>
To: Hiroshi DOYU <hdoyu@nvidia.com>
Cc: linux-tegra@vger.kernel.org, Colin Cross <ccross@android.com>,
Olof Johansson <olof@lixom.net>,
Stephen Warren <swarren@wwwdotorg.org>,
Russell King <linux@arm.linux.org.uk>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] ARM: tegra: Add AHB driver
Date: Mon, 23 Apr 2012 15:06:46 +0300 [thread overview]
Message-ID: <20120423120645.GY26302@arwen.pp.htv.fi> (raw)
In-Reply-To: <1335181043-15348-1-git-send-email-hdoyu@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 456 bytes --]
Hi,
On Mon, Apr 23, 2012 at 02:37:21PM +0300, Hiroshi DOYU wrote:
> +static inline unsigned long gizmo_readl(unsigned long offset)
> +{
> + return readl(IO_TO_VIRT(TEGRA_AHB_GIZMO_BASE + offset));
> +}
> +
> +static inline void gizmo_writel(unsigned long value, unsigned long offset)
> +{
> + writel(value, IO_TO_VIRT(TEGRA_AHB_GIZMO_BASE + offset));
> +}
why don't you ioremap() your address and use it as a void __iomem * ?
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-04-23 12:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-23 11:37 [PATCH 1/3] ARM: tegra: Add AHB driver Hiroshi DOYU
2012-04-23 11:37 ` [PATCH 2/3] ARM: tegra: Add SMMU enabler in AHB Hiroshi DOYU
2012-04-23 12:09 ` Felipe Balbi
2012-04-23 11:37 ` [PATCH 3/3] iommu/tegra: smmu: Refrain from accessing to AHB registers Hiroshi DOYU
2012-04-23 12:06 ` Felipe Balbi [this message]
2012-04-23 12:33 ` [PATCH 1/3] ARM: tegra: Add AHB driver Arnd Bergmann
2012-04-23 18:00 ` Stephen Warren
2012-04-23 18:32 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120423120645.GY26302@arwen.pp.htv.fi \
--to=balbi@ti.com \
--cc=ccross@android.com \
--cc=hdoyu@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=olof@lixom.net \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox