From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Pavel Machek <pavel@denx.de>,
kernel list <linux-kernel@vger.kernel.org>,
wd@denx.de
Subject: Re: Sharing header files -- arch/arm/mach-generic ?
Date: Mon, 23 Apr 2012 20:15:41 +0000 [thread overview]
Message-ID: <201204232015.41963.arnd@arndb.de> (raw)
In-Reply-To: <20120423194042.GA5734@elf.ucw.cz>
On Monday 23 April 2012, Pavel Machek wrote:
> I have new architecture I'd like to merge into the mainline. It has
> some code very similar to existing plaforms (for example
> real differences to mach-realview/platsmp.c are two lines.)
>
> Is that a problem?
>
> Should mach-generic/platsmp.c be created, so code can be better
> shared? Or are the code pieces small enough that this duplication can
> be ignored?
Hi Pavel,
I'd suggest you just post the code with the duplicate files
for review at first, and then we can discuss what to do with them.
As Russell mentioned, the code might not actually be ideal
in the duplicate version so you end up rewriting it, or there
might be a different solution that someone finds when we see the
patches.
Arnd
prev parent reply other threads:[~2012-04-23 20:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-23 19:40 Sharing header files -- arch/arm/mach-generic ? Pavel Machek
2012-04-23 19:52 ` Russell King - ARM Linux
2012-04-23 20:15 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201204232015.41963.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@denx.de \
--cc=wd@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox