From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932267Ab2DXK0G (ORCPT ); Tue, 24 Apr 2012 06:26:06 -0400 Received: from tx2ehsobe002.messaging.microsoft.com ([65.55.88.12]:15501 "EHLO tx2outboundpool.messaging.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756632Ab2DXK0F (ORCPT ); Tue, 24 Apr 2012 06:26:05 -0400 X-SpamScore: -6 X-BigFish: VS-6(zcb8kz1432N98dKzz1202hzzz2dh2a8h668h839h944hd25h) X-Forefront-Antispam-Report: CIP:70.37.183.190;KIP:(null);UIP:(null);IPV:NLI;H:mail.freescale.net;RD:none;EFVD:NLI Date: Tue, 24 Apr 2012 18:36:11 +0800 From: Dong Aisheng To: Richard Zhao CC: Dong Aisheng , , , , , , , , , , Subject: Re: [PATCH v2 3/3] ARM: imx6q: switch to use pinctrl driver Message-ID: <20120424103610.GE32166@shlinux2.ap.freescale.net> References: <1334933916-12971-1-git-send-email-b29396@freescale.com> <1334933916-12971-3-git-send-email-b29396@freescale.com> <20120424095116.GA28063@b20223-02.ap.freescale.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20120424095116.GA28063@b20223-02.ap.freescale.net> User-Agent: Mutt/1.5.20 (2009-06-14) X-OriginatorOrg: freescale.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 24, 2012 at 05:51:17PM +0800, Richard Zhao wrote: > > --- a/drivers/mmc/host/sdhci-esdhc-imx.c > > +++ b/drivers/mmc/host/sdhci-esdhc-imx.c > > @@ -24,6 +24,7 @@ > > #include > > #include > > #include > > +#include > > #include > > #include "sdhci-pltfm.h" > > #include "sdhci-esdhc.h" > > @@ -68,6 +69,7 @@ struct pltfm_imx_data { > > int flags; > > u32 scratchpad; > > enum imx_esdhc_type devtype; > > + struct pinctrl *p; > > struct esdhc_platform_data boarddata; > > }; > > > > @@ -467,6 +469,12 @@ static int __devinit sdhci_esdhc_imx_probe(struct platform_device *pdev) > > clk_prepare_enable(clk); > > pltfm_host->clk = clk; > > > > + imx_data->p = pinctrl_get_select_default(&pdev->dev); > devm_xxx version? > Yes, Stephen also mentioned it. Will update it. Regards Dong Aisheng