From: "Henrik Rydberg" <rydberg@euromail.se>
To: Daniel Kurtz <djkurtz@chromium.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Joonyoung Shim <jy0922.shim@samsung.com>,
Nick Dyer <nick.dyer@itdev.co.uk>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Benson Leung <bleung@chromium.org>,
Yufeng Shen <miletus@chromium.org>
Subject: Re: [PATCH 03/14 v3] Input: atmel_mxt_ts - refactor mxt_read/write_reg to take a length
Date: Tue, 24 Apr 2012 13:23:19 +0200 [thread overview]
Message-ID: <20120424112319.GA9688@polaris.bitmath.org> (raw)
In-Reply-To: <1334755319-21365-4-git-send-email-djkurtz@chromium.org>
Hi Daniel,
> The i2c bus requires 5 bytes to do a 1 byte read (1-byte i2c address + 2
> byte offset + 1-byte i2c address + 1 byte data), or 4 bytes to do a
> 1-byte write (1 byte i2c address + 2 byte offset + 1 byte data).
>
> By taking a length with reads and writes, the driver can amortize
> transaction overhead by performing larger transactions where appropriate.
>
> This patch just sets up the new API. Later patches refactor reads/writes
> to take advantage of the larger transactions.
>
> These functions are also now return any errors reported by the i2c layer.
>
> Signed-off-by: Daniel Kurtz <djkurtz@chromium.org>
> ---
In the cyttsp a dedicate tx buffer is used, which is a bit easier on
the eyes. OTOH, the write operation seems infrequent enough to not
matter much, so
Acked-by: Henrik Rydberg <rydberg@euromail.se>
Thanks for your patience,
Henrik
next prev parent reply other threads:[~2012-04-24 11:19 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-18 13:21 [PATCH 00/14 v3] cleanup atmel_mxt_ts Daniel Kurtz
2012-04-18 13:21 ` [PATCH 01/14 v3] Input: atmel_mxt_ts - use CONFIG_PM_SLEEP Daniel Kurtz
2012-04-18 13:21 ` [PATCH 02/14 v3] Input: atmel_mxt_ts - only allow root to update firmware Daniel Kurtz
2012-04-18 13:21 ` [PATCH 03/14 v3] Input: atmel_mxt_ts - refactor mxt_read/write_reg to take a length Daniel Kurtz
2012-04-24 11:23 ` Henrik Rydberg [this message]
2012-05-09 5:50 ` Dmitry Torokhov
2012-05-09 5:54 ` Dmitry Torokhov
2012-05-09 7:05 ` Jean Delvare
2012-05-09 7:25 ` Dmitry Torokhov
2012-04-18 13:21 ` [PATCH 04/14 v3] Input: atmel_mxt_ts - verify object size in mxt_write_object Daniel Kurtz
2012-04-18 13:21 ` [PATCH 05/14 v3] Input: atmel_mxt_ts - do not read extra (checksum) byte Daniel Kurtz
2012-04-18 13:21 ` [PATCH 06/14 v3] Input: atmel_mxt_ts - dump each message on just 1 line Daniel Kurtz
2012-04-18 13:21 ` [PATCH 07/14 v3] Input: atmel_mxt_ts - refactor mxt_object_show Daniel Kurtz
2012-04-18 13:21 ` [PATCH 08/14 v3] Input: atmel_mxt_ts - optimize writing of object table entries Daniel Kurtz
2012-04-18 13:21 ` [PATCH 09/14 v3] Input: atmel_mxt_ts - refactor get info Daniel Kurtz
2012-05-05 17:41 ` Nick Dyer
2012-05-06 2:43 ` Daniel Kurtz
2012-04-18 13:21 ` [PATCH 10/14 v3] Input: atmel_mxt_ts - simplify event reporting Daniel Kurtz
2012-04-18 13:21 ` [PATCH 11/14 v3] Input: atmel_mxt_ts - cache T9 reportid range when reading object table Daniel Kurtz
2012-04-18 13:21 ` [PATCH 12/14 v3] Input: atmel_mxt_ts - parse vector field of data packets Daniel Kurtz
2012-04-18 13:21 ` [PATCH 13/14 v3] Input: atmel_mxt_ts - send all MT-B slots in one input report Daniel Kurtz
2012-04-18 13:21 ` [PATCH 14/14 v3] Input: atmel_mxt_ts - parse T6 reports Daniel Kurtz
2012-05-04 17:39 ` [PATCH 00/14 v3] cleanup atmel_mxt_ts Daniel Kurtz
2012-05-05 12:16 ` Henrik Rydberg
2012-05-05 13:01 ` Daniel Kurtz
2012-05-09 5:48 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120424112319.GA9688@polaris.bitmath.org \
--to=rydberg@euromail.se \
--cc=bleung@chromium.org \
--cc=djkurtz@chromium.org \
--cc=dmitry.torokhov@gmail.com \
--cc=jy0922.shim@samsung.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miletus@chromium.org \
--cc=nick.dyer@itdev.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox