From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Jean Delvare <khali@linux-fr.org>
Cc: Laxman Dewangan <ldewangan@nvidia.com>,
w.sang@pengutronix.de, ben-linux@fluff.org,
swarren@wwwdotorg.org, olof@lixom.net, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V1 2/2] i2c: tegra: support for I2C_M_NOSTART protocol mangling
Date: Tue, 24 Apr 2012 13:40:31 +0100 [thread overview]
Message-ID: <20120424124030.GD13747@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20120424143241.0d66fd2e@endymion.delvare>
[-- Attachment #1: Type: text/plain, Size: 797 bytes --]
On Tue, Apr 24, 2012 at 02:32:41PM +0200, Jean Delvare wrote:
> Please keep in mind that support for I2C_M_NOSTART at the bus driver
> level is optional. This means that device drivers are encouraged to not
> rely on it unconditionally. Originally the flag was meant to workaround
Yeah, for regmap we certainly have a fallback to kmalloc() a buffer as
needed in there already. Like I say it's just an optimisation.
> If you want to do scatter-gather for I2C messages, I understand the
> benefit and I have no objection, and I agree that I2C_M_NOSTART lets
> you do that, but then:
> * We should allocate a new functionality flag for it.
> * We should update the documentation to reflect the two use cases.
That sounds like a good plan. I'll try to get round to it if nobody
beats me to it.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-04-24 12:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-24 7:19 [PATCH V1 0/2] i2c: tegra: 10 bit and M_NOSTART support Laxman Dewangan
2012-04-24 7:19 ` [PATCH V1 1/2] i2c: tegra: fix 10bit address configuration Laxman Dewangan
2012-04-24 8:58 ` Jean Delvare
2012-05-03 6:13 ` Laxman Dewangan
2012-05-03 8:18 ` Wolfram Sang
2012-05-03 8:20 ` Laxman Dewangan
2012-04-24 7:19 ` [PATCH V1 2/2] i2c: tegra: support for I2C_M_NOSTART protocol mangling Laxman Dewangan
2012-04-24 8:55 ` Jean Delvare
2012-04-24 9:21 ` Laxman Dewangan
2012-04-24 11:38 ` Mark Brown
2012-04-24 12:32 ` Jean Delvare
2012-04-24 12:40 ` Mark Brown [this message]
2012-04-24 13:01 ` Wolfram Sang
2012-04-24 13:07 ` Jean Delvare
2012-04-24 13:28 ` Wolfram Sang
2012-05-10 11:24 ` Laxman Dewangan
2012-05-10 11:54 ` Jean Delvare
2012-05-10 12:20 ` Laxman Dewangan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120424124030.GD13747@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=ben-linux@fluff.org \
--cc=khali@linux-fr.org \
--cc=ldewangan@nvidia.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
--cc=swarren@wwwdotorg.org \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox