From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Dong Aisheng <b29396@freescale.com>
Cc: linux-kernel@vger.kernel.org, linus.walleij@stericsson.com,
devicetree-discuss@lists.ozlabs.org, rob.herring@calxeda.com,
linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de,
s.hauer@pengutronix.de
Subject: Re: [PATCH v2 3/3] ARM: imx6q: switch to use pinctrl driver
Date: Tue, 24 Apr 2012 14:46:34 +0200 [thread overview]
Message-ID: <20120424124634.GH9142@game.jcrosoft.org> (raw)
In-Reply-To: <1334933916-12971-3-git-send-email-b29396@freescale.com>
On 22:58 Fri 20 Apr , Dong Aisheng wrote:
> From: Dong Aisheng <dong.aisheng@linaro.org>
>
> Signed-off-by: Dong Aisheng <dong.aisheng@linaro.org>
>
> ---
> This is not a formal patch and is only used for test
> since before the pinctrl core handle dummy state is in,
> enable pinctrl in driver will break other platforms.
>
> ChangeLog v1->v2:
> * using updated binding
> ---
> arch/arm/boot/dts/imx6q-arm2.dts | 2 ++
> arch/arm/boot/dts/imx6q.dtsi | 17 +++++++++++++++++
> arch/arm/mach-imx/Kconfig | 2 ++
> drivers/mmc/host/sdhci-esdhc-imx.c | 12 ++++++++++++
> 4 files changed, 33 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx6q-arm2.dts b/arch/arm/boot/dts/imx6q-arm2.dts
> index ce1c823..68b1d8d 100644
> --- a/arch/arm/boot/dts/imx6q-arm2.dts
> +++ b/arch/arm/boot/dts/imx6q-arm2.dts
> @@ -44,6 +44,8 @@
> fsl,card-wired;
> vmmc-supply = <®_3p3v>;
> status = "okay";
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_usdhc4_1>;
> };
>
> uart4: uart@021f0000 {
> diff --git a/arch/arm/boot/dts/imx6q.dtsi b/arch/arm/boot/dts/imx6q.dtsi
> index 4905f51..8cbd88b 100644
> --- a/arch/arm/boot/dts/imx6q.dtsi
> +++ b/arch/arm/boot/dts/imx6q.dtsi
> @@ -386,7 +386,24 @@
> };
>
> iomuxc@020e0000 {
> + compatible = "fsl,imx6q-iomuxc";
> reg = <0x020e0000 0x4000>;
> +
> + /* shared pinctrl settings */
> + usdhc4 {
> + pinctrl_usdhc4_1: usdhc4grp-1 {
> + fsl,pins = <1386 0x17059 /* MX6Q_PAD_SD4_CMD__USDHC4_CMD */
> + 1392 0x17059 /* MX6Q_PAD_SD4_CLK__USDHC4_CLK */
> + 1462 0x17059 /* MX6Q_PAD_SD4_DAT0__USDHC4_DAT0 */
> + 1470 0x17059 /* MX6Q_PAD_SD4_DAT1__USDHC4_DAT1 */
> + 1478 0x17059 /* MX6Q_PAD_SD4_DAT2__USDHC4_DAT2 */
> + 1486 0x17059 /* MX6Q_PAD_SD4_DAT3__USDHC4_DAT3 */
> + 1493 0x17059 /* MX6Q_PAD_SD4_DAT4__USDHC4_DAT4 */
> + 1501 0x17059 /* MX6Q_PAD_SD4_DAT5__USDHC4_DAT5 */
> + 1509 0x17059 /* MX6Q_PAD_SD4_DAT6__USDHC4_DAT6 */
> + 1517 0x17059>; /* MX6Q_PAD_SD4_DAT7__USDHC4_DAT7 */
Can you on IMX have alternative onfiguration where you use as example just one
pin on a different pad?
Best Regards,
J.
next prev parent reply other threads:[~2012-04-24 14:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-20 14:58 [PATCH v2 1/3] pinctrl: pinctrl-imx: add imx pinctrl core driver Dong Aisheng
2012-04-20 14:58 ` [PATCH v2 2/3] pinctrl: pinctrl-imx: add imx6q pinctrl driver Dong Aisheng
2012-04-20 14:58 ` [PATCH v2 3/3] ARM: imx6q: switch to use " Dong Aisheng
2012-04-24 8:56 ` Linus Walleij
2012-04-24 9:08 ` Wolfram Sang
2012-04-24 9:43 ` Dong Aisheng
2012-04-24 9:15 ` Dong Aisheng
2012-04-24 9:51 ` Richard Zhao
2012-04-24 10:36 ` Dong Aisheng
2012-04-24 12:46 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2012-04-24 14:04 ` Dong Aisheng
2012-04-24 14:48 ` Jean-Christophe PLAGNIOL-VILLARD
2012-04-24 9:02 ` [PATCH v2 1/3] pinctrl: pinctrl-imx: add imx pinctrl core driver Linus Walleij
2012-04-25 7:04 ` Richard Zhao
2012-04-25 12:10 ` Dong Aisheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120424124634.GH9142@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=b29396@freescale.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=kernel@pengutronix.de \
--cc=linus.walleij@stericsson.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rob.herring@calxeda.com \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox