Re: [PATCH 33/43] userns: Convert binary formats to use kuid/kgid where appropriate

Eric W. Biederman
2012-04-24T02:40:34Z

"Serge E. Hallyn" <serge@hallyn.com> writes:

> Quoting Eric W. Beiderman (ebiederm@xmission.com):
>> From: Eric W. Biederman <ebiederm@xmission.com>
>>
>> Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
>
> Ok I'll spare the list the traffic - for patches 33-43,
>
> Acked-by: Serge Hallyn <serge.hallyn@canonical.com>

I noticed one other significant gotcha with my changes.

Code that has not been converted and needs to be converted fails to
build with type errors. -- Good.

Code that has not been converted and needs to be converted is still
selectable in make config. -- Bad

make oldmodconfig -- fails with type errors unless everything is
converted Bad.

So I am adding/debugging an additional patch that will catch these
failure in Kconfig so people don't get nasty surprises.

Eric