Re: [PATCH 1/4] perf tools: Fix include header files in util/parse-events.h

[Arnaldo Carvalho de Melo <acme@redhat.com>]

Em Tue, Apr 24, 2012 at 06:53:44PM +0200, Robert Richter escreveu:
> On 05.04.12 18:26:25, Robert Richter wrote:
> > Include header fixes for
> > 
> > ... bool:
> > 
> >  util/parse-events.h:31: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘have_tracepoints’
> > 
> > ... and types.h:
> > 
> >  util/parse-events.h:28: error: expected ‘)’ before ‘config’
> >  util/parse-events.h:34: error: expected declaration specifiers or ‘...’ before ‘u64’
> >  util/parse-events.h:45: error: expected ‘)’ before ‘type’
> > 
> > This happens if now other include files are included before
> > util/parse-events.h.
> > 
> > Signed-off-by: Robert Richter <robert.richter@amd.com>
> 
> Arnaldo,
> 
> is it your intention that you didn't apply this patch?

Is this on perf/urgent or perf/core? In what system does this happen?

- Arnaldo
 
> Thanks,
> 
> -Robert
> 
> > ---
> >  tools/perf/util/parse-events.h |    2 ++
> >  1 files changed, 2 insertions(+), 0 deletions(-)
> > 
> > diff --git a/tools/perf/util/parse-events.h b/tools/perf/util/parse-events.h
> > index 6d7c74b..ab6ebe0 100644
> > --- a/tools/perf/util/parse-events.h
> > +++ b/tools/perf/util/parse-events.h
> > @@ -4,7 +4,9 @@
> >   * Parse symbolic events/counts passed in as options:
> >   */
> >  
> > +#include <stdbool.h>
> >  #include "../../../include/linux/perf_event.h"
> > +#include "types.h"
> >  
> >  struct list_head;
> >  struct perf_evsel;
> > -- 
> > 1.7.8.4
> > 
> 
> -- 
> Advanced Micro Devices, Inc.
> Operating System Research Center