From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756954Ab2DXSqr (ORCPT ); Tue, 24 Apr 2012 14:46:47 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:45164 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756607Ab2DXSqq (ORCPT ); Tue, 24 Apr 2012 14:46:46 -0400 Date: Tue, 24 Apr 2012 11:46:42 -0700 From: Greg KH To: =?iso-8859-1?Q?St=E9phane?= Pajot Cc: rdunlap@xenotime.net, fmhess@users.sourceforge.net, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Staging: comedi: fix trailing whitespace and quoted string split across lines in ni_labpc.c Message-ID: <20120424184642.GA20004@kroah.com> References: <1335286210-3150-1-git-send-email-pajot.stephane@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1335286210-3150-1-git-send-email-pajot.stephane@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 24, 2012 at 06:50:10PM +0200, Stéphane Pajot wrote: > This is a patch to the ni_labpc.c file that fixes up trailing whitespace error and quoted string split across lines warning > found by the checkpatch.pl tool Please only fix one type of thing per patch, so this should be a two patch series at the least. But... > @@ -738,7 +738,7 @@ static int labpc_attach(struct comedi_device *dev, struct comedi_devconfig *it) > irq = it->options[1]; > dma_chan = it->options[2]; > #else > - printk(KERN_ERR " this driver has not been built with ISA DMA " > + printk(KERN_ERR " this driver has not been built with ISA DMA\n" > "support.\n"); What? Why did you do this? Do you understand what you just did to the message printed out? greg k-h