From: Greg KH <gregkh@linuxfoundation.org>
To: "Stéphane Pajot" <pajot.stephane@gmail.com>
Cc: devel@driverdev.osuosl.org, fmhess@users.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: comedi: fix trailing whitespace and quoted string split across lines in ni_labpc.c
Date: Tue, 24 Apr 2012 13:00:58 -0700 [thread overview]
Message-ID: <20120424200058.GA14071@kroah.com> (raw)
In-Reply-To: <20120424192709.GA4717@stef-pc>
On Tue, Apr 24, 2012 at 09:27:09PM +0200, Stéphane Pajot wrote:
> On Tue, Apr 24, 2012 at 11:46:42AM -0700, Greg KH wrote:
> > On Tue, Apr 24, 2012 at 06:50:10PM +0200, Stéphane Pajot wrote:
> > > @@ -738,7 +738,7 @@ static int labpc_attach(struct comedi_device *dev, struct comedi_devconfig *it)
> > > irq = it->options[1];
> > > dma_chan = it->options[2];
> > > #else
> > > - printk(KERN_ERR " this driver has not been built with ISA DMA "
> > > + printk(KERN_ERR " this driver has not been built with ISA DMA\n"
> > > "support.\n");
> >
> > What? Why did you do this? Do you understand what you just did to the
> > message printed out?
>
> ... It was just to patch this "quoted string split across lines
> warning", i saw this solution on the web. Now i think i understand that
> i cannot modify AT ALL a printk(KERN_ERR* even if it's just with a \n ?
Think about what is actually happening here. You do know C, right?
What is the output of the line before you made the change, and now
after?
thanks,
greg k-h
next prev parent reply other threads:[~2012-04-24 20:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1335286210-3150-1-git-send-email-pajot.stephane@gmail.com>
2012-04-24 18:46 ` [PATCH] Staging: comedi: fix trailing whitespace and quoted string split across lines in ni_labpc.c Greg KH
2012-04-24 19:27 ` Stéphane Pajot
2012-04-24 20:00 ` Greg KH [this message]
2012-04-24 20:03 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120424200058.GA14071@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=fmhess@users.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=pajot.stephane@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox