Re: [ 49/62] KVM: unmap pages from the iommu when slots are removed

Greg KH
2012-04-30T05:06:08Z

On Fri, Apr 27, 2012 at 04:08:27PM -0600, Alex Williamson wrote:
> On Fri, 2012-04-27 at 16:54 -0500, Jonathan Nieder wrote:
> > Hi,
> >
> > Greg KH wrote:
> >
> > > 3.3-stable review patch.
> > [...]
> > > commit 32f6daad4651a748a58a3ab6da0611862175722f upstream.
> > >
> > > We've been adding new mappings, but not destroying old mappings.
> > > This can lead to a page leak
> >
> > Does 3.0.y need this?
>
> Yep, same issues exists there.
>
> > The patch does not apply as is to 3.0.y because
> > the latter lacks v3.3-rc1~131^2~41 ("KVM: introduce kvm_for_each_memslot
> > macro"), but a backport is straightforward.
> >
> > Completely untested. Test results and other comments welcome.
>
> Looks correct to me.
>
> Acked-by: Alex Williamson <alex.williamson@redhat.com>

Wonderful, now applied.