Re: [ 43/62] usb: gadget: udc-core: fix asymmetric calls in remove_driver

Greg KH
2012-04-26T21:16:38Z

On Thu, Apr 26, 2012 at 01:34:35AM +0100, Ben Hutchings wrote:
> On Tue, Apr 24, 2012 at 03:33:24PM -0700, Greg KH wrote:
> > 3.3-stable review patch. If anyone has any objections, please let me know.
> >
> > ------------------
> >
> > From: Kishon Vijay Abraham I <kishon@ti.com>
> >
> > commit 8ae8090c82eb407267001f75b3d256b3bd4ae691 upstream.
> >
> > During modprobe of gadget driver, pullup is called after
> > udc_start. In order to make the exit path symmetric when
> > removing a gadget driver, call pullup before ->udc_stop.
> [...]
>
> It looks like commit 6d258a4c42089229b855fd706622029decf316d6
> (previous patch in this series!) added another case where the
> cleanup functions are called in the wrong order.

Felipe? Any thoughts?