Re: [ 03/62] hwmon: fam15h_power: fix bogus values with current BIOSes

Guenter Roeck
2012-04-26T16:49:59Z

On Thu, 2012-04-26 at 12:43 -0400, Greg KH wrote:
> On Wed, Apr 25, 2012 at 01:50:02PM -0700, Guenter Roeck wrote:
> > On Wed, 2012-04-25 at 15:45 -0400, Ben Hutchings wrote:
> > > On Tue, Apr 24, 2012 at 03:32:44PM -0700, Greg KH wrote:
> > > > 3.3-stable review patch. If anyone has any objections, please let me know.
> > > [...]
> > > > +static void __devinit tweak_runavg_range(struct pci_dev *pdev)
> > > > +{
> > > > + u32 val;
> > > > + const struct pci_device_id affected_device = {
> > > > + PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_15H_NB_F4) };
> > > > +
> > > > + /*
> > > > + * let this quirk apply only to the current version of the
> > > > + * northbridge, since future versions may change the behavior
> > > > + */
> > > > + if (!pci_match_id(&affected_device, pdev))
> > > > + return;
> > > [...]
> > >
> > > pci_match_id() takes an *array* of IDs which must be properly zero-
> > > terminated. This change is bogus and should be fixed up before it
> > > goes into a stable update.
> >
> > Good catch. I sent a patch to fix this in mainline a minute ago.
>
> Is it in Linus's tree yet? If so, what's the git commit id? If not,
> I'll have to drop it from this release.

It is not in Linus' tree yet. I plan to send the pull request tomorrow,
after having it rest for another night in my tree (with nightly builds)
and in linux-next.

Please drop the patch for now. The fix will include a reference to it,
so you can pull both patches once the fix shows up in Linus' tree.

Sorry for the trouble.

Thanks,
Guenter