From: Ingo Molnar <mingo@kernel.org>
To: David Miller <davem@davemloft.net>
Cc: joe@perches.com, linux-kernel@vger.kernel.org,
akpm@linux-foundation.org, torvalds@linux-foundation.org,
apw@canonical.com
Subject: Re: Please fix or revert: [PATCH] checkpatch: add --strict tests for braces, comments and casts
Date: Wed, 25 Apr 2012 10:42:02 +0200 [thread overview]
Message-ID: <20120425084202.GB20853@gmail.com> (raw)
In-Reply-To: <20120416.165804.411912709558079358.davem@davemloft.net>
(Sorry about the late reply, was busy with other things.)
* David Miller <davem@davemloft.net> wrote:
> From: Ingo Molnar <mingo@kernel.org>
> Date: Mon, 16 Apr 2012 22:26:54 +0200
>
> > If you don't "see" it as ugly it's simply because your brain
> > is not wired up to see 3D/2D geometry as a significant
> > source of information.
>
> I'm sorry that I'm so handicapped that I cannot match your
> visual capabilitites.
I genuinely think that it's the other way around: if what I say
above is true then *you* have the superior vision for coding.
Geometric properties of code are a distraction really, they
don't matter to the end result.
So in reality keeping comments balanced helps *my* disability:
my inability to ignore functionally irrelevant patterns of
characters...
So I am asking *you* to do me a favor: please understand my
perspective and insert a bit more whitespace to keep code
readable for people like me.
( The wider question is, what is the contribution weighted
proportion of the two groups of kernel developers and what is
the disutility and utility of the two variants. It's a
difficult balancing task and there's no perfect solution. )
Thanks,
Ingo
next prev parent reply other threads:[~2012-04-25 8:42 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-16 9:17 Please fix or revert: [PATCH] checkpatch: add --strict tests for braces, comments and casts Ingo Molnar
2012-04-16 18:27 ` David Miller
2012-04-16 19:09 ` Linus Torvalds
2012-04-16 19:13 ` David Miller
2012-04-16 20:26 ` Ingo Molnar
2012-04-16 20:34 ` Joe Perches
2012-04-16 20:34 ` Ingo Molnar
2012-04-16 21:00 ` David Miller
2012-04-17 3:30 ` Steven Rostedt
2012-04-25 8:33 ` Ingo Molnar
2012-04-16 20:58 ` David Miller
2012-04-25 8:42 ` Ingo Molnar [this message]
2012-04-16 19:44 ` Randy Dunlap
2012-04-16 19:32 ` [PATCH] checkpatch: revert --strict test for net/ and drivers/net block comment style Joe Perches
2012-04-16 19:35 ` Joe Perches
2012-04-16 20:28 ` Ingo Molnar
2012-04-16 20:33 ` Linus Torvalds
2012-04-17 10:07 ` Ingo Molnar
2012-04-25 22:42 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120425084202.GB20853@gmail.com \
--to=mingo@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=davem@davemloft.net \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox