From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757291Ab2DYSKV (ORCPT ); Wed, 25 Apr 2012 14:10:21 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:51619 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753096Ab2DYSKU (ORCPT ); Wed, 25 Apr 2012 14:10:20 -0400 Date: Wed, 25 Apr 2012 11:10:15 -0700 From: Greg Kroah-Hartman To: Rusty Russell Cc: linux-kernel@vger.kernel.org, Alessio Igor Bogani , Tony Lindgren , Ben Hutchings , Russell King Subject: [PATCH] modpost: use proper kernel style for autogenerated files Message-ID: <20120425181015.GA7921@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If the kernel build process is creating files automatically, the least it can do is create them in a properly formatted manner. Sure, it's a minor issue, but being consistent is nice. Cc: Rusty Russell Cc: Alessio Igor Bogani Cc: Tony Lindgren Cc: Ben Hutchings Cc: Russell King Signed-off-by: Greg Kroah-Hartman diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c index c4e7d15..05748b3 100644 --- a/scripts/mod/modpost.c +++ b/scripts/mod/modpost.c @@ -1850,14 +1850,14 @@ static void add_header(struct buffer *b, struct module *mod) buf_printf(b, "\n"); buf_printf(b, "struct module __this_module\n"); buf_printf(b, "__attribute__((section(\".gnu.linkonce.this_module\"))) = {\n"); - buf_printf(b, " .name = KBUILD_MODNAME,\n"); + buf_printf(b, "\t.name = KBUILD_MODNAME,\n"); if (mod->has_init) - buf_printf(b, " .init = init_module,\n"); + buf_printf(b, "\t.init = init_module,\n"); if (mod->has_cleanup) buf_printf(b, "#ifdef CONFIG_MODULE_UNLOAD\n" - " .exit = cleanup_module,\n" + "\t.exit = cleanup_module,\n" "#endif\n"); - buf_printf(b, " .arch = MODULE_ARCH_INIT,\n"); + buf_printf(b, "\t.arch = MODULE_ARCH_INIT,\n"); buf_printf(b, "};\n"); }