Re: [PATCH] Btrfs: avoid buffer overrun in mount option handling

[Josef Bacik <josef@redhat.com>]

On Wed, Apr 25, 2012 at 09:51:53PM +0200, Jim Meyering wrote:
> 
> There is an off-by-one error: allocating room for a maximal result
> string but without room for a trailing NUL.  That, can lead to
> returning a transformed string that is not NUL-terminated, and then
> to a caller reading beyond end of the malloc'd buffer.
> 
> Worse still, we could write one non-NUL byte beyond the end of that
> malloc'd result buffer when given a mount option of "subvol=," (i.e.,
> no arg after the "=") because here the replacement "subvolid=0" is 3
> bytes longer, not just 2.

So this can't happen, since it would be caught by btrfs_parse_early_options
which expects subvolid=%d, and if it doesn't get that it would just error out,
so while adding another byte isn't bad, it's not correct either, so fix that and
I'd say it's good to go.  Thanks,

Josef