From: Greg KH <gregkh@linuxfoundation.org>
To: "Javier M. Mellid" <jmunhoz@igalia.com>
Cc: gewang@siliconmotion.com, boyod.yang@siliconmotion.com.cn,
wuzhangjin@gmail.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: sm7xx: code improvements and cleanup
Date: Wed, 25 Apr 2012 13:55:32 -0700 [thread overview]
Message-ID: <20120425205532.GA9642@kroah.com> (raw)
In-Reply-To: <1335387028-29652-1-git-send-email-jmunhoz@igalia.com>
On Wed, Apr 25, 2012 at 10:50:28PM +0200, Javier M. Mellid wrote:
> This patch implements some code improvements and cleanup.
>
> New code uses dynamic debug support. Old debug calls updated/tested to
> use this API.
>
> Cleanup on obsolete references, internal versions and some
> comments. Dead code removal.
>
> Patch tested with SM712.
>
> Changes:
>
> - Code improvements and cleanup
> - Use dynamic debug support
> - Remove out-of-date comments/references
> - Remove dead code
Can you please break this down into individual patches, each doing only
one thing, so that we can review it easier? Otherwise, it's quite
difficult, which is one reason why we require patches to be created this
way.
thanks,
greg k-h
next prev parent reply other threads:[~2012-04-25 20:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-25 20:50 [PATCH] staging: sm7xx: code improvements and cleanup Javier M. Mellid
2012-04-25 20:55 ` Greg KH [this message]
2012-04-25 21:05 ` Javier Muñoz
2012-04-26 18:45 ` [PATCH RESEND 0/7] " Javier M. Mellid
2012-04-27 7:44 ` Dan Carpenter
2012-05-03 20:37 ` Javier Muñoz
2012-04-30 1:33 ` Greg KH
2012-05-03 20:39 ` Javier Muñoz
2012-04-26 18:45 ` [PATCH RESEND 1/7] staging: sm7xx: remove old references and non updated comments Javier M. Mellid
2012-04-26 18:45 ` [PATCH RESEND 2/7] staging: sm7xx: dead code removal Javier M. Mellid
2012-04-26 18:45 ` [PATCH RESEND 3/7] staging: sm7xx: use dynamic debug support Javier M. Mellid
2012-04-26 18:45 ` [PATCH RESEND 4/7] staging: sm7xx: use dynamic debug support to show info and errors Javier M. Mellid
2012-04-26 18:45 ` [PATCH RESEND 5/7] staging: sm7xx: merge hardware information in smtcfb_info struct Javier M. Mellid
2012-04-26 18:45 ` [PATCH RESEND 6/7] staging: sm7xx: remove driver version support Javier M. Mellid
2012-04-26 18:45 ` [PATCH RESEND 7/7] staging: sm7xx: rename function Javier M. Mellid
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120425205532.GA9642@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=boyod.yang@siliconmotion.com.cn \
--cc=devel@driverdev.osuosl.org \
--cc=gewang@siliconmotion.com \
--cc=jmunhoz@igalia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=wuzhangjin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox