Re: [PATCH] percpu, x86: don't use PMD_SIZE as embedded atom_size on 32bit

Tejun Heo
2012-04-27T17:27:08Z

On Fri, Apr 27, 2012 at 12:21:34PM -0500, Christoph Lameter wrote:
> On Fri, 27 Apr 2012, Tejun Heo wrote:
>
> > This patch makes x86_32 always use PAGE_SIZE as atom_size for embed
> > first chunk allocator.
>
> Would it not be easier to use the first #ifdef in the function to set
> pcpu_chosen_fc = PCPU_FC_PAGE?
>
> You could just skip the whole PCPU_FC_PAGE block in the CONFIG_X86_32
> case.

PCPU_FC_PAGE != PCPU_FC_EMBED w/ PAGE_SIZE atom_size. EMBED still
gets to piggy back on the kernel linear mapping for the first chunk
unlike PAGE. It apparently created noticeable difference (I'm
guessing due to extra TLB pressure) for intel android folks.

Thanks.

--
tejun