Re: [tip:core/locking] watchdog, hpwdt: Remove priority option for NMI callback

[Don Zickus <dzickus@redhat.com>]

On Thu, Apr 26, 2012 at 09:13:39AM +0200, Wim Van Sebroeck wrote:
> > 
> > Therefore hpwdt's priority mechanism doesn't make sense any
> > more.  They will be always first on the NMI_UNKNOWN queue, if
> > they register.
> > 
> > Removing this parameter cleans up the code and simplifies things
> > for the next patch which changes how nmis are registered.
> > 
> > Signed-off-by: Don Zickus <dzickus@redhat.com>
> > Cc: Thomas Mingarelli <thomas.mingarelli@hp.com>
> > Cc: Wim Van Sebroeck <wim@iguana.be>
> > Cc: Peter Zijlstra <peterz@infradead.org>
> > Cc: Linus Torvalds <torvalds@linux-foundation.org>
> > Cc: Andrew Morton <akpm@linux-foundation.org>
> > Link: http://lkml.kernel.org/r/1333051877-15755-2-git-send-email-dzickus@redhat.com
> > Signed-off-by: Ingo Molnar <mingo@kernel.org>
> 
> This is the feedback I have from Tom which he discussed with Don:
> > I don't like this patch because the Virtual NMI button doesn't come through the pretimeout routine. It is taken by the
> system as an IOCK NMI error and no log messages in our IML.
> > Our BIOS is not able to source the NMI.
> 
> And since then it became quiet. Imho: this needs more discussion...

Tom and I discussed this offline.  The result was patch 2 of this series.
The problem he had, had nothing to do with this patch (which was just a
cleanup really).  Tom tested the second patch and was happy with the
results.

If there is any other issues, I am assuming Tom would have let me know a
while ago.  But I believe all his issues are addressed.  Tom?

Cheers,
Don