From: Robert Richter <robert.richter@amd.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: "Stephane Eranian" <eranian@google.com>,
LKML <linux-kernel@vger.kernel.org>,
"Arnaldo Carvalho de Melo" <acme@redhat.com>,
mingo@elte.hu, "David Ahern" <dsahern@gmail.com>,
"Frédéric Weisbecker" <fweisbec@gmail.com>,
"Jiri Olsa" <jolsa@redhat.com>
Subject: Re: [BUG] perf stat: useless output for raw events with new event parser
Date: Thu, 26 Apr 2012 15:12:20 +0200 [thread overview]
Message-ID: <20120426131220.GB5046@erda.amd.com> (raw)
In-Reply-To: <1335436031.13683.6.camel@twins>
On 26.04.12 12:27:11, Peter Zijlstra wrote:
> Furthermore, once we have a common format, we could even ask Intel/AMD
> (and other vendors) to provide their data in this format.
I don't think that can be done with a reasonable effort. Trying to
abstract the pmu description in sysfs to let user space know about the
pmu? We will never fit everything. And we have duplicate code,
esp. bit masks etc in the kernel and userland. What has been simple
bit mask macros in the past are now tons of bit name and mask pairs
provided by sysfs, generated by the kernel and reassembled in
userland. Could it be any more complicated? Really this can't be
handled.
Why not simply pass an identifier for each kind of pmu and then only
add pmu specific code in userland? Much easier than all this sysfs
format thing, where the kernel tries to tell userland what to do,
which the kernel never can do exactly. And even if we can describe
everything with sysfs, kernel and userland code becomes bloated, it
actually is already, looking at the recent perf tool and kernel
updates.
-Robert
--
Advanced Micro Devices, Inc.
Operating System Research Center
next prev parent reply other threads:[~2012-04-26 13:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-23 10:45 [BUG] perf stat: useless output for raw events with new event parser Stephane Eranian
2012-04-23 10:48 ` Peter Zijlstra
2012-04-23 10:55 ` Jiri Olsa
2012-04-23 10:56 ` Robert Richter
2012-04-23 11:17 ` Stephane Eranian
2012-04-26 10:27 ` Peter Zijlstra
2012-04-26 12:53 ` Stephane Eranian
2012-04-26 14:03 ` Peter Zijlstra
2012-04-26 13:12 ` Robert Richter [this message]
2012-04-26 14:24 ` Peter Zijlstra
2012-04-26 14:45 ` Robert Richter
2012-04-26 15:39 ` Peter Zijlstra
2012-04-26 17:36 ` Robert Richter
2012-05-07 12:42 ` Peter Zijlstra
2012-05-07 16:58 ` Robert Richter
2012-04-23 10:57 ` Jiri Olsa
2012-05-02 11:14 ` Stephane Eranian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120426131220.GB5046@erda.amd.com \
--to=robert.richter@amd.com \
--cc=acme@redhat.com \
--cc=dsahern@gmail.com \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox