Re: [PATCH 02/11] blkcg: __blkg_lookup_create() doesn't have to fail on radix tree preload failure

Vivek Goyal
2012-04-27T14:43:09Z

On Thu, Apr 26, 2012 at 02:59:12PM -0700, Tejun Heo wrote:
> __blkg_lookup_create() currently fails if radix_tree_preload() fails;
> however, preload failrue doesn't imply insertion failure. Don't fail
> __blkg_lookup_create() on preload failure.
>

Hi Tejun,

If we are going to try the insertion anyway irrespective of the fact
whether preload succeeded or not, they why call radix_tree_preload()
at all? How does that help?

Thanks
Vivek